Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix lifetime of GlobalLogHandler #3221

Merged

Merge branch 'main' into try_fix_lifetime_of_global_log_handler

2245d89
Select commit
Loading
Failed to load commit list.
Merged

[SDK] Fix lifetime of GlobalLogHandler #3221

Merge branch 'main' into try_fix_lifetime_of_global_log_handler
2245d89
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2025 in 0s

88.15% (-0.00%) compared to 3b89346

View this Pull Request on Codecov

88.15% (-0.00%) compared to 3b89346

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (3b89346) to head (2245d89).

Files with missing lines Patch % Lines
...lude/opentelemetry/sdk/common/global_log_handler.h 81.82% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3221      +/-   ##
==========================================
- Coverage   88.16%   88.15%   -0.00%     
==========================================
  Files         198      198              
  Lines        6224     6236      +12     
==========================================
+ Hits         5487     5497      +10     
- Misses        737      739       +2     
Files with missing lines Coverage Δ
sdk/src/common/global_log_handler.cc 77.42% <100.00%> (+6.59%) ⬆️
...lude/opentelemetry/sdk/common/global_log_handler.h 64.00% <81.82%> (-1.00%) ⬇️