Add Windows build and refactor goreleaser config generation #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-releases into fancy-approach-windows-build
Thanks for the contribution Douglas! Can you implement the refactoring in a separate PR from the functional change? This should make code review much more effective. |
@andrzej-stencel: Sure thing. I'll open a separate PR for the refactor, cross-reference this one and close it so that we can focus on the new one. |
|
Opened #797, which should be only the refactor but without the Windows containers parts, @andrzej-stencel. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #339, while at the same time moving the code for generating the
goreleaserconfiguration for the distros into a more declarative and easy-to-extend form.The Windows build will be producing images based on Windows 2019 and 2022.
Why so many changes? 😱
I am completely aware that it represents a big rewrite of this part of code. I tried a few different approaches with the intent of having a minimum change that would allow me to support Windows, but the amount of changes needed always ended up snowballing quickly. Some examples of the reasons for this "snowballing" of code are (non-exhaustive list):
This might not the best code for this job too, but at least I believe it sets up a good structure that we can build upon and iterate on to improve.
I'm very open to hear your feedback and see how we can move this forward!
I can join the Collector SIG call on 2025-01-15 to talk about this if any maintainer finds it more productive.
Questions ⍰
If anyone, please, could help me out in testing that release process works fine with the update goreleaser configuration, it would be aaaaamazing! I don't feel super confident without testing this, of course.