Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: enable early-return from revive #37119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[chore]: enable early-return from revive #37119

wants to merge 1 commit into from
+122 −139

Conversation

mmorel-35
Copy link
Contributor

Description

early-return: In Go it is idiomatic to minimize nesting statements, a typical example is to avoid if-then-else constructions.

@mmorel-35 mmorel-35 changed the title chore: enable early-return from revive [chore]: enable early-return from revive Jan 9, 2025
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 4e5e126 to e0f1a49 Compare January 9, 2025 19:24
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from e0f1a49 to 30d22ab Compare January 9, 2025 19:40
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 30d22ab to 5b8a767 Compare January 9, 2025 19:47
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 5b8a767 to 88afdef Compare January 9, 2025 20:08
@github-actions github-actions bot added the exporter/datadog Datadog components label Jan 9, 2025
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 88afdef to 4e4838d Compare January 9, 2025 20:13
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 4e4838d to da95aa7 Compare January 9, 2025 20:20
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from da95aa7 to f45517a Compare January 9, 2025 20:28
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch 2 times, most recently from defecb1 to 69daecf Compare January 9, 2025 20:36
@mmorel-35 mmorel-35 marked this pull request as ready for review January 9, 2025 20:44
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 69daecf to 36350ff Compare January 9, 2025 20:49
@mmorel-35 mmorel-35 force-pushed the revive/early-return branch from 36350ff to 77fdc66 Compare January 9, 2025 20:51
@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@mxiamxia mxiamxia Awaiting requested review from mxiamxia

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@songy23 songy23 Awaiting requested review from songy23 songy23 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dashpole dashpole

Labels
ci-cd CI, CD, testing, build issues confmap/provider/aesprovider exporter/datadog Datadog components exporter/dataset exporter/honeycombmarker exporter/prometheus exporter/signalfx exporter/sumologic internal/aws internal/sqlquery pkg/stanza receiver/awscontainerinsight receiver/awss3 receiver/azureeventhub receiver/cloudfoundry receiver/kubeletstats receiver/prometheus Prometheus receiver receiver/saphana receiver/solace receiver/splunkhec receiver/sqlserver receiver/windowsperfcounters receiver/zookeeper testbed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @dashpole @songy23