Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom requestID generation #287

Merged
merged 1 commit into from
May 28, 2021
Merged

feat: support custom requestID generation #287

merged 1 commit into from
May 28, 2021

Conversation

zcstarr
Copy link
Member

@zcstarr zcstarr commented May 28, 2021

This feature is to support generating requestID in either a string or
numeric format. Additionally this will support multiple clients
operating against the same context.

The goal here is to allow systems like client generator to
pass through this option to other downstream operators

fixes #277 , fixes #279

@zcstarr zcstarr requested a review from shanejonas May 28, 2021 15:57
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #287 (e512bd5) into master (b8bf358) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   99.24%   99.25%           
=======================================
  Files          11       11           
  Lines         396      400    +4     
  Branches       60       61    +1     
=======================================
+ Hits          393      397    +4     
  Misses          3        3           
Impacted Files Coverage Δ
src/RequestManager.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8bf358...e512bd5. Read the comment docs.

"requires": true,
"packages": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think something went wrong here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah version update reverting package-lock.json

@zcstarr zcstarr requested a review from shanejonas May 28, 2021 16:34
This feature is to support generating requestID in either a string or
numeric format. Additionally this will support multiple clients
operating against the same context.

The goal here is to allow systems like client generator to
pass through this option to other downstream operators

fixes #277 , fixes #279
@zcstarr zcstarr merged commit c57ab3b into master May 28, 2021
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable request ID feature: Adding option to use custom Id in request
3 participants