Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable request ID #279

Closed
BelfordZ opened this issue Apr 15, 2021 · 1 comment · Fixed by #287
Closed

Configurable request ID #279

BelfordZ opened this issue Apr 15, 2021 · 1 comment · Fixed by #287
Labels
released

Comments

@BelfordZ
Copy link
Member

BelfordZ commented Apr 15, 2021 •
edited
Loading

The request ID generated by the client has a couple of issues.

  1. no way to force the type to be integer or string (alleviate issues such as Cannot parse non-numerical ID filecoin-project/go-jsonrpc#28)
  2. no way to configure how the 'next id' is created (see: feature: Adding option to use custom Id in request #277)

Further, there are cases where some libraries expect a string only, or integer only. In those cases, this library can provide a fairly straight forward way for users to work around the issue.

This Issue is to discuss solutions to the problem. A good solution is one that:

  1. provides very quick/easy way to use numbers instead of strings
  2. provides a way to give a custom function to produce an ID for each request
This was referenced Apr 16, 2021
Closed
Merged
zcstarr added a commit that referenced this issue May 28, 2021
@zcstarr
feat: support custom requestID generation
b452f6e 
This feature is to support generating requestID in either a string or
numeric format. Additionally this will support multiple clients
operating against the same context.

The goal here is to allow systems like client generator to
pass through this option to other downstream operators

fixes #277 , fixes #279
@zcstarr zcstarr mentioned this issue May 28, 2021
Merged
zcstarr added a commit that referenced this issue May 28, 2021
@zcstarr
feat: support custom requestID generation
b898bbe 
This feature is to support generating requestID in either a string or
numeric format. Additionally this will support multiple clients
operating against the same context.

The goal here is to allow systems like client generator to
pass through this option to other downstream operators

fixes #277 , fixes #279
zcstarr added a commit that referenced this issue May 28, 2021
@zcstarr
feat: support custom requestID generation
2cfc650 
This feature is to support generating requestID in either a string or
numeric format. Additionally this will support multiple clients
operating against the same context.

The goal here is to allow systems like client generator to
pass through this option to other downstream operators

fixes #277 , fixes #279
zcstarr added a commit that referenced this issue May 28, 2021
@zcstarr
feat: support custom requestID generation
e512bd5 
This feature is to support generating requestID in either a string or
numeric format. Additionally this will support multiple clients
operating against the same context.

The goal here is to allow systems like client generator to
pass through this option to other downstream operators

fixes #277 , fixes #279
openrpc-bastion added a commit that referenced this issue May 28, 2021
@openrpc-bastion
chore(release): 1.7.0 [skip ci]
1c804a4 
# [1.7.0](1.6.3...1.7.0) (2021-05-28)

### Features

* support custom requestID generation ([e512bd5](e512bd5)), closes [#277](#277) [#279](#279)
@openrpc-bastion
Copy link
Member

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support custom requestID generation open-rpc/client-js
2 participants
@BelfordZ @openrpc-bastion