Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpdbg: Add On Chip Controller (OCC) hardware unit #91

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

SwethaParasa
Copy link
Contributor

OCC is not in hardware unit list as it is not guardable. But, when a proc is guarded OCC is deconfigured by association. Currently we are not seeing OCC in Nag Dump because of unavailable properties like "name" and "class". So, Adding OCC to hardware unit list.

Test Results:

Before:

OCC was not showing up in Nag Dump.

After:

root@p10bmc:/tmp/test# faultlog -f
<6> faultlog app to collect deconfig/guard records details <6> Latest chassis poweron time read is :03/20/2024 15:33:49 [
  {
    "SYSTEM": {
      "SYSTEM_TYPE": "9105-42A"
    }
  },
  {
    "POLICY": {
      "FCO_VALUE": 0,
      "MASTER": true,
      "PREDICTIVE": true
    }
  },
  {
    "MANUAL_ISOLATION": {
      "CURRENT_STATE": "DECONFIGURED",
      "LOCATION_CODE": "Ufcs-P0-C15",
      "PHYS_PATH": "physical:sys-0/node-0/proc-1",
      "REASON_DESCRIPTION": "MANUAL",
      "TYPE": "Processor Module"
    }
  },
  {
    "DECONFIGURED": {
      "CURRENT_STATE": "DECONFIGURED",
      "LOCATION_CODE": "Ufcs-P0-C15",
      "PHYS_PATH": "physical:sys-0/node-0/proc-1/nx-0",
      "PLID": 0,
      "REASON_DESCRIPTION": "MANUAL",
      "TYPE": "POWER10 Nest Accelerator unit"
    }
  },
  {
    "DECONFIGURED": {
      "CURRENT_STATE": "DECONFIGURED",
      "LOCATION_CODE": "Ufcs-P0-C15",
      "PHYS_PATH": "physical:sys-0/node-0/proc-1/occ-0",  --> OCC is added now
      "PLID": 0,
      "REASON_DESCRIPTION": "MANUAL",
      "TYPE": "POWER10 On Chip Controller"
    }
  },

Change-Id: I5930cc4135b1573e56e9ea6a1967a69632e59e20

OCC is not in hardware unit list as it is not guardable. But, when a proc is
guarded OCC is deconfigured by association. Currently we are not seeing OCC in
Nag Dump because of unavailable properties like "name" and "class". So, Adding
OCC to hardware unit list.

Test Results:

Before:

OCC was not showing up in Nag Dump.

After:

root@p10bmc:/tmp/test# faultlog -f
<6> faultlog app to collect deconfig/guard records details
<6> Latest chassis poweron time read is :03/20/2024 15:33:49
[
  {
    "SYSTEM": {
      "SYSTEM_TYPE": "9105-42A"
    }
  },
  {
    "POLICY": {
      "FCO_VALUE": 0,
      "MASTER": true,
      "PREDICTIVE": true
    }
  },
  {
    "MANUAL_ISOLATION": {
      "CURRENT_STATE": "DECONFIGURED",
      "LOCATION_CODE": "Ufcs-P0-C15",
      "PHYS_PATH": "physical:sys-0/node-0/proc-1",
      "REASON_DESCRIPTION": "MANUAL",
      "TYPE": "Processor Module"
    }
  },
  {
    "DECONFIGURED": {
      "CURRENT_STATE": "DECONFIGURED",
      "LOCATION_CODE": "Ufcs-P0-C15",
      "PHYS_PATH": "physical:sys-0/node-0/proc-1/nx-0",
      "PLID": 0,
      "REASON_DESCRIPTION": "MANUAL",
      "TYPE": "POWER10 Nest Accelerator unit"
    }
  },
  {
    "DECONFIGURED": {
      "CURRENT_STATE": "DECONFIGURED",
      "LOCATION_CODE": "Ufcs-P0-C15",
      "PHYS_PATH": "physical:sys-0/node-0/proc-1/occ-0",  --> OCC is added now
      "PLID": 0,
      "REASON_DESCRIPTION": "MANUAL",
      "TYPE": "POWER10 On Chip Controller"
    }
  },

Change-Id: I5930cc4135b1573e56e9ea6a1967a69632e59e20
Signed-off-by: SwethaParasa <[email protected]>
@aravynd aravynd merged commit c1199fe into open-power:master Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants