Remove possible intermediate states of the http request conversion to AST #629
+42
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pushpalanka Jayawardhana <[email protected]>
|
Does this PR achieve the objective of this PR? |
Thanks for the reference @ashutosh-narkar. After having a further look we are now trying the possibility of getting rid of all the intermediate states than just JSON conversions and translating http request directly to the AST.Values. (mainly this section) Will update the PR accordingly. Please do share if you see in pitfalls with the approach. |
Pushpalanka
changed the title
|
That seems reasonable. If you have any benchmarks that show the performance improvement that would be great to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove intermediate conversions between the HTTP request to AST input.
Motive: From the below profile capture it was noticed most of the CPU time is spent on these conversions. (It is from a slightly older version of OPA)
Pending new results..