-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Refactor COCOMetric, CocoOccludedSeparatedMetric, and ProposalRecallMetric by using MMEval #9079
Open
BIGWangYuDong
wants to merge
19
commits into
open-mmlab:refactor_metrics
Choose a base branch
from
BIGWangYuDong:mmeval_coco
base: refactor_metrics
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Refactor] Refactor COCOMetric, CocoOccludedSeparatedMetric, and ProposalRecallMetric by using MMEval #9079
BIGWangYuDong
wants to merge
19
commits into
open-mmlab:refactor_metrics
from
BIGWangYuDong:mmeval_coco
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BIGWangYuDong
changed the title
[WIP] Update COCOMetric to use MMEval
[WIP] Update COCOMetric and ProposalRecallMetric to use MMEval
Oct 21, 2022
BIGWangYuDong
changed the title
[WIP] Update COCOMetric and ProposalRecallMetric to use MMEval
[Refactor] Refactor COCOMetric and ProposalRecallMetric by using MMEval
Feb 21, 2023
RangiLyu
reviewed
Feb 27, 2023
Supporting saving coco summarize information |
RangiLyu
reviewed
Feb 27, 2023
RangiLyu
reviewed
Feb 27, 2023
RangiLyu
reviewed
Feb 27, 2023
RangiLyu
approved these changes
Feb 28, 2023
BIGWangYuDong
changed the title
[Refactor] Refactor COCOMetric and ProposalRecallMetric by using MMEval
[Refactor] Refactor COCOMetric, CocoOccludedSeparatedMetric, and ProposalRecallMetric by using MMEval
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follor PR: open-mmlab/mmeval#23 and open-mmlab/mmeval#29
should be merged after open-mmlab/mmeval#98 and open-mmlab/mmeval#112 has been merged
CocoMetric
Before refactor
After refactor
Not load ann_file:
The area in coco is based on gt_mask. if using gt_bbox, it will lead to different small/medium/large AP results. Moreover, the area calculated from gt_mask area in CocoDetectionMetric is almost equal to coco-json file (still a little difference in small AP). So if only calculate bbox ap, and do not load ann_file, it is suggested to load mask at the same time.
Using gt_box area:
Using gt_mask area:
Load ann_file:
ProposalRecallMetric
Before refactor
After refactor
CocoOccludedSeparatedMetric
Before refactor
After refactor