Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4825] Fix prefill when authentication is needed #5010

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[#4825] Fix prefill when authentication is needed #5010

wants to merge 1 commit into from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 10, 2025

Closes #4825

Changes

  • Run prefill plugin only when the authentication type matches the plugin's requirements.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh

  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft January 10, 2025 13:06
@vaszig vaszig force-pushed the fix/4825-2-digest-reports-prefill-failures-when-multiple-auth-flows branch 2 times, most recently from e434ad9 to cde7242 Compare January 10, 2025 13:10
@vaszig
[#4825] Fixed prefill when authentication is needed
2dcf088 
In case a form needs authentication and uses prefill, we need to make
sure that we run the plugin only when the authentication type matches
the plugin's requirements.
@vaszig vaszig force-pushed the fix/4825-2-digest-reports-prefill-failures-when-multiple-auth-flows branch from cde7242 to 2dcf088 Compare January 10, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daily digest reporting prefill failures for forms that work with more then 1 auth "flow"
1 participant
@vaszig