Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-digid-eherkenning #4997

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

sergei-maertens
Copy link
Member

This release has extra options for eherkenning/eidas metadata configuration.

Closes #4785

Changes

Upgraded to new release of django-digid-eherkenning package which provides the required configuration options.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (044d136) to head (0070a90).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4997   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files         761      761           
  Lines       25959    25959           
  Branches     3394     3394           
=======================================
  Hits        25093    25093           
  Misses        601      601           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens force-pushed the issue/4785-bump-digid-eh-lib branch from adf672a to bea75ad Compare January 8, 2025 11:54
This release has extra options for eherkenning/eidas metadata
configuration.
@sergei-maertens sergei-maertens force-pushed the issue/4785-bump-digid-eh-lib branch from bea75ad to 0070a90 Compare January 10, 2025 13:42
@sergei-maertens sergei-maertens merged commit e59012c into master Jan 10, 2025
32 checks passed
@sergei-maertens sergei-maertens deleted the issue/4785-bump-digid-eh-lib branch January 10, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feedback Signicat/kpn on generated eHerkenning metadata.xml
1 participant