Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor text updates to sustainability.md and sustainability.yaml #491

Merged
merged 7 commits into from
Sep 24, 2024

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Jul 25, 2024

Related issues

closes #489 I also noticed a few more instances of "labour" rather than "labor" so fixed them too

Description

Merge checklist

Its such minor changes I don't think we need a changelog entry, let me know if you think we do and I can add one

If there are changes to project-schema.json or project-package-schema.json:

  • Update the examples:
    • docs/examples/example.json
    • docs/examples/blank.json
  • Run ./manage.py pre-commit to update docs/_static/i8n.csv

If you added a new definition to the schema, run ./manage.py pre-commit.

If you added a new codelist:

  • Add an entry to docs/reference/codelists.md

@odscjen odscjen requested a review from duncandewhurst July 25, 2024 15:37
Copy link
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good apart from the one I commented on.

mapping/sustainability.yaml Outdated Show resolved Hide resolved
@odscjen odscjen requested a review from jpmckinney September 24, 2024 13:33
@odscjen
Copy link
Contributor Author

odscjen commented Sep 24, 2024

I attempted to run .manage.py pre-commit and got the following error

File "/***/infrastructure/./manage.py", line 176, in _get_definition_references
_get_definition_references(value, defn, [*parents, key], project_schema, include_nested)
TypeError: pre_commit.._get_definition_references() takes from 2 to 4 positional arguments but 5 were given

@jpmckinney
Copy link
Member

I attempted to run .manage.py pre-commit and got the following error

Fixed

@jpmckinney jpmckinney merged commit c84c6a4 into 0.9-dev Sep 24, 2024
11 checks passed
@jpmckinney jpmckinney deleted the 489-sustainability-text-updates branch September 24, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text updates to IDS sustainability module elements
3 participants