Corrected test and added asserts to check emptyStrings at ColloscopeC…

…lient init
onyx-lyon1 · Oct 20, 2023 · f4e62b7 · f4e62b7
1 parent 49b0139
commit f4e62b7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/polytechcolloscopeclient/lib/src/polytechcolloscopeclient_base.dart b/packages/polytechcolloscopeclient/lib/src/polytechcolloscopeclient_base.dart
@@ -8,7 +8,10 @@ import 'consts.dart';
 class PolytechColloscopeClient {
   final String username, password;
 
-  PolytechColloscopeClient(this.username, this.password);
+  PolytechColloscopeClient(this.username, this.password) {
+    assert(username.isNotEmpty);
+    assert(password.isNotEmpty);
+  }
 
   Future<List<Student>> fetchStudents(Year year) async {
     var page = await RequestsPlus.get(Consts.kholleURL[year]!,

diff --git a/packages/polytechcolloscopeclient/test/polytechcolloscopeclient_test.dart b/packages/polytechcolloscopeclient/test/polytechcolloscopeclient_test.dart
@@ -13,7 +13,8 @@ Future<void> main() async {
     fail("username or password were empty. check your envt variables");
   }
 
-  PolytechColloscopeClient client = PolytechColloscopeClient("", "");
+  PolytechColloscopeClient client =
+      PolytechColloscopeClient(username, password);
 
   var students = await client.fetchStudents(Year.first);
   print(students);