Fixed Multi-selection functionality. #9345
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,126 @@ | ||
| class PatientInvestigation { | ||
| private elements = { | ||
| addInvestigation: () => cy.get("#investigation"), | ||
| investigationTab: () => cy.get("#consultation_tab_nav"), | ||
| searchPatientInvestigation: () => cy.get("#search-patient-investigation"), | ||
| investigationGroup: () => cy.get("#investigation-group"), | ||
| investigationCheckbox: () => cy.get("#investigation-checkbox"), | ||
| investigationSelect: () => cy.get("#investigation-select"), | ||
| logLabResults: () => cy.get("#log-lab-results"), | ||
| investigationFrequency: () => cy.get("#investigation-frequency"), | ||
| }; | ||
|
|
||
| clickAddInvestigation() { | ||
| cy.log("Clicking Add Investigation"); | ||
| this.elements | ||
| .addInvestigation() | ||
| .should("be.visible") | ||
| .contains("Add Investigation") | ||
| .click(); | ||
| cy.wait(1000); | ||
| } | ||
|
|
||
| clickInvestigationTab() { | ||
| cy.log("Clicking Investigation Tab"); | ||
| this.elements | ||
| .investigationTab() | ||
| .should("be.visible") | ||
| .contains("Investigations") | ||
| .click(); | ||
| cy.wait(2000); | ||
| } | ||
|
|
||
| selectInvestigation(investigation: string) { | ||
| cy.log(`Selecting Investigation: ${investigation}`); | ||
|
|
||
| this.elements | ||
| .searchPatientInvestigation() | ||
| .should("be.visible") | ||
| .clear() | ||
| .type(investigation, { delay: 100 }); | ||
|
|
||
| this.elements | ||
| .investigationGroup() | ||
| .contains(investigation) | ||
| .should("be.visible") | ||
| .click(); | ||
|
|
||
| this.elements | ||
| .addInvestigation() | ||
| .contains("Investigation No. 1") | ||
| .should("be.visible") | ||
| .click(); | ||
| } | ||
|
|
||
| clickInvestigationCheckbox() { | ||
| cy.log("Clicking Investigation Checkbox"); | ||
| this.elements | ||
| .investigationCheckbox() | ||
| .should("be.visible") | ||
| .should("be.enabled") | ||
| .click(); | ||
| } | ||
|
|
||
| selectInvestigationOption(options: string[]) { | ||
| cy.log("Selecting Investigation Options:", options); | ||
|
|
||
| this.elements | ||
| .investigationSelect() | ||
| .should("exist") | ||
| .should("be.visible") | ||
| .click(); | ||
|
|
||
| options.forEach((option) => { | ||
| cy.get("[role='option']") | ||
| .contains(option) | ||
| .should("be.visible") | ||
| .then(($el) => { | ||
| if ($el.length > 0) { | ||
| cy.wrap($el).click(); | ||
| } else { | ||
| throw new Error(`Option "${option}" not found in dropdown`); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| cy.get("body").click(0, 0); | ||
| cy.wait(500); | ||
| } | ||
|
|
||
| clickLogLabResults() { | ||
| cy.log("Clicking Log Lab Results"); | ||
|
|
||
| this.elements.logLabResults().scrollIntoView().should("be.visible"); | ||
|
|
||
| cy.wait(1000); | ||
|
|
||
| this.elements | ||
| .logLabResults() | ||
| .contains("Log Lab Results") | ||
| .should("be.visible") | ||
| .should("be.enabled") | ||
| .click(); | ||
|
|
||
| cy.wait(2000); | ||
| } | ||
|
|
||
| selectInvestigationFrequency(frequency: string) { | ||
| cy.log(`Selecting Investigation Frequency: ${frequency}`); | ||
|
|
||
| this.elements.investigationFrequency().should("be.visible").click(); | ||
|
|
||
| cy.contains("button", frequency).should("be.visible").click(); | ||
|
|
||
| cy.wait(500); | ||
| } | ||
|
|
||
| verifyElementPresent(selector: string, timeout = 10000) { | ||
| return cy.get(selector, { timeout }).should("exist").should("be.visible"); | ||
| } | ||
|
|
||
| waitForLoading() { | ||
| cy.get("#loading-indicator", { timeout: 10000 }).should("not.exist"); | ||
| } | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. 💡 Codebase verification Test coverage is incomplete for multi-selection scenarios The current test implementation only partially covers the required scenarios. Here are the gaps identified:
The page object has the necessary methods ( 🔗 Analysis chainVerify coverage of all multi-selection scenarios. While the test file has been updated to handle multi-selection, please ensure it covers all scenarios mentioned in issue #9144, including:
Let's verify the test coverage: Let me gather more information about the test coverage: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for related test cases in the codebase
echo "Searching for related test files..."
fd -e cy.ts -e spec.ts "Investigation"
echo "Checking for multi-select testing patterns..."
rg -l "selectInvestigationOption.*\[.*\]" -t ts
echo "Checking for Clear button test coverage..."
rg -l "clear.*button|clear.*selection" -t ts
Length of output: 746 Script: #!/bin/bash
# Check the actual test implementation
echo "Checking PatientInvestigation test implementation..."
cat cypress/e2e/patient_spec/PatientInvestigation.cy.ts
# Look for clear functionality in the page object
echo -e "\nChecking clear functionality in page object..."
rg "clear" cypress/pageobject/Patient/PatientInvestigation.ts
# Check for any multi-select related code in the component
echo -e "\nChecking multi-select implementation in components..."
rg -A 5 "multiSelect|multiple" src/components/Form/AutoCompleteAsync.tsx src/components/Form/FormFields/Autocomplete.tsx
Length of output: 5394 |
||
| export default PatientInvestigation; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve robustness of multi-selection handling.
The current implementation has several areas for improvement:
Consider this improved implementation:
selectInvestigationOption(options: string[]) { cy.log("Selecting Investigation Options:", options); this.elements .investigationSelect() .should("exist") .should("be.visible") .click(); options.forEach((option) => { cy.get("[role='option']") .contains(option) - .should("be.visible") + .should("be.visible", { timeout: 5000 }) .then(($el) => { if ($el.length > 0) { cy.wrap($el).click(); + // Verify selection was successful + cy.get(".selected-option").should("contain", option); } else { - throw new Error(`Option "${option}" not found in dropdown`); + throw new Error( + `Option "${option}" not found in dropdown. Available options: ${ + $el.parent().text() + }` + ); } }); }); - cy.get("body").click(0, 0); - cy.wait(500); + // Close dropdown using the dropdown trigger itself + this.elements.investigationSelect().click(); + // Verify dropdown is closed + cy.get("[role='option']").should("not.exist"); }📝 Committable suggestion