Merge Develop To Staging November Third Week #9087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfigured in env if any (#9052)
Co-authored-by: rithviknishad <[email protected]>
* Ventilator Data - Added ventilator data as table on Ventilator tab - Added Marker Area to graphs under ventilator tab * MarkerLine and MarkerArea - To do: cleanup (only keep whichever one is chosen, cleanup commented out code) * MarkLine, rm MarkArea code - Choosing markLine as that represents the data accurately (when switching to bar graph) * Rm markArea import * added overflow to table/mobile view * render most recent mode/modality on graph * log fixes * IV/NIV log text modification * Fixes and cleanup - Switched VentilatorPlot to use getDailyReports (instead of getDailyRoundsAnalyse). - Changed end_date to be based on next daily round (rather than round with ventilator data) - Pagination on top level (in the tab, instead of in Plots) - Applies to both Table and the Graphs * Cleanup - Removed filtering items in VentorTable beforehand - allowing to fetch the right end date - as well as only combining rounds with same NIV/IV/Oxygen mode/modality if there are consecutive (i.e. no round in between them) - VentilatorPlot - adjust label position for the first data point (to avoid overflow of line label into y axis labels) * Pagination Limit - Added limit of 36 (same as before for pagination in VentilatorPlot) * using date utils * improvement suggestions * Nitpick fixes * type fix * lint fix
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CARE
|
||||||||||||||||||||||||||||
| Project |
CARE
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 04m 46s |
| Commit |
|
| Committer | Mohammed Nihal |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
126
|
| View all changes introduced in this branch ↗︎ | |
Deploying care-fe with
|
| Latest commit: |
5bb46fa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8184c741.care-fe.pages.dev |
Co-authored-by: Khavin Shankar <[email protected]>
…e than results per page (#9004)
Co-authored-by: Mohammed Nihal <[email protected]>
) Co-authored-by: rithviknishad <[email protected]>
* added non-core-qn workflow * replaced bash with js * made it to single step * updated to use env * setup variables as secrets * applied coderabbitai suggested changes * Improved Slack message. * updated the script to use vars instead of secrets uu * use slack workflow instead of slCK APPS slack
khavinshankar
approved these changes
Nov 13, 2024
|
@nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist