-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace useDispatch in Patient Files (src/Components/Patient/) #7078
Replace useDispatch in Patient Files (src/Components/Patient/) #7078
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👋 Hi, @konavivekramakrishna, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
https://www.loom.com/share/10e513d00b0d48a6844142999459389a?sid=a201b096-6014-45eb-83da-bb1e54b29af9 @rithviknishad can you please review and I have checked and updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor improvement
const dummyPatientData = Object.assign({}, patientData); | ||
dummyPatientData["assigned_to"] = assignedVolunteerObject; | ||
setPatientData(dummyPatientData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch patient API would return the updated patient object as response. Use that instead of manipulating the object from client side.
setPatientData(res.data);
👋 Hi, @konavivekramakrishna, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
LGTM |
@konavivekramakrishna We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Proposed Changes
useDispatch
w.useQuery
/request
: Patient (src/Components/Patient/**
) #6546@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist