Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace useDispatch in Patient Files (src/Components/Patient/) #7078

Merged
merged 57 commits into from
Feb 14, 2024

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Jan 22, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 7:27am

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3334cfc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65cc6b1145d45f0008a1f8ca
😎 Deploy Preview https://deploy-preview-7078--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/Redux/api.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 24, 2024
Copy link

👋 Hi, @konavivekramakrishna,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@konavivekramakrishna
Copy link
Contributor Author

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor improvement

Comment on lines 145 to 147
const dummyPatientData = Object.assign({}, patientData);
dummyPatientData["assigned_to"] = assignedVolunteerObject;
setPatientData(dummyPatientData);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch patient API would return the updated patient object as response. Use that instead of manipulating the object from client side.

setPatientData(res.data);

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 12, 2024
Copy link

👋 Hi, @konavivekramakrishna,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Feb 13, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit d36c0f2 into ohcnetwork:develop Feb 14, 2024
35 of 36 checks passed
Copy link

@konavivekramakrishna We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠️ Replace useDispatch w. useQuery/request: Patient (src/Components/Patient/**)
6 participants