Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate filters cache upon login attempt #6823

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 8, 2023

WHAT

🤖[deprecated] Generated by Copilot at f09fee7

The pull request adds a feature to clear the cached filters from the local storage when the user logs in. This is done by defining and calling the invalidateFiltersCache function in src/Utils/utils.ts and src/Components/Auth/Login.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at f09fee7

  • Invalidate filters cache on user login to show latest data without stale filters (link, link, link)
  • Import invalidateFiltersCache function from src/Utils/utils.ts in Login component (link)
  • Call invalidateFiltersCache function inside useEffect hook of Login component (link)
  • Define invalidateFiltersCache function in src/Utils/utils.ts to remove local storage keys that start with filters-- (link)

@rithviknishad rithviknishad requested a review from a team as a code owner December 8, 2023 12:39
Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f09fee7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65730e7cbd857a0007cde11e
😎 Deploy Preview https://deploy-preview-6823--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 0:39am

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Dec 8, 2023
@nihal467
Copy link
Member

nihal467 commented Dec 8, 2023

LGTM

@khavinshankar khavinshankar merged commit 896f51b into develop Dec 8, 2023
35 of 44 checks passed
@khavinshankar khavinshankar deleted the invalidate-filters-cache-upon-login branch December 8, 2023 13:15
Copy link

github-actions bot commented Dec 8, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing P1 breaking issue or vital feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidate filters cache upon sign in
3 participants