Implement Splash Screen for Services Application #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,7 +110,7 @@ | |||
| <activity | |||
| android:name=".MainActivity" | |||
| android:label="@string/app_name" | |||
| android:theme="@style/ODKX"> | |||
| android:theme="@style/SplashTheme"> | |||
There was a problem hiding this comment.
Why change the complete Services style?
There was a problem hiding this comment.
Hi @Redeem-Grimm-Satoshi
The Android documentation recommends setting the Main Activity's theme to the one created specifically for the Splash Screen
This is required because the Splash Screen theme must be applied to the Main Activity to display the Splash Screen when the app launches. After the Splash Screen is dismissed, the Main Activity’s theme will automatically switch to @style/ODKX, as defined by the postSplashScreenTheme attribute within the @style/SplashScreen theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes odk-x/tool-suite-X#500
This PR adds Splash Screen implementation to the Services Application.
Recordings
Services Light.webm
Services Dark.webm