Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ppx import in ood #2930

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Use ppx import in ood #2930

wants to merge 10 commits into from

Conversation

cuihtlauac
Copy link
Collaborator

@cuihtlauac cuihtlauac commented Jan 20, 2025

Move @@deriving attributes from Data_intf to ood/lib files

Module Data_intf does not need to expose Yaml parsing or
pp/show functions at runtime. This is only used when crunching
the data. Types are duplicated in ood using ppx_import and
ppx_deriving is applied to those definitions.

Staged preprocessing is used.

Some modules aren't moved yet:

  • Academic_institution
  • Blog
  • Governance
  • Video
  • Planet

The former four because they have field-level attributes which
aren't supported by ppx_import

The latter because it depends on Blog and Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant