chore: Promote change of unix; threads -> threads.posix
#11199
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Kubica <[email protected]>
|
Hmm, clearly CI disagrees that this change makes sense. Strangely I do have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
dune buildit promotes this change (at least on my machine). I don't know why this is happening or whether this is correct. From my cursory understandinthreadswill always pickthreads.posixasthreads.vmis deprecated but I don't know which change on caused this and whether this is the right thing to do.Thus I am opening this PR as a to open a discussion but I am not sure if the proposed solution is the correct one.