-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M cell and FAE partonomy update #2897
base: master
Are you sure you want to change the base?
M cell and FAE partonomy update #2897
Conversation
#gogoeditdiff |
Here's a diff of how these changes impact the classified ontology (on -base file):Ontology comparisonLeft
Right
Ontology importsOntology annotationsM cell of gut
|
Here's a diff of your edit file (unreasoned)Ontology comparisonLeft
Right
Ontology importsOntology annotationsM cell of gut
|
@@ -9506,7 +9506,7 @@ AnnotationAssertion(rdfs:label obo:CL_0000682 "M cell of gut") | |||
SubClassOf(obo:CL_0000682 obo:CL_0000066) | |||
SubClassOf(obo:CL_0000682 obo:CL_0000473) | |||
SubClassOf(obo:CL_0000682 obo:CL_0000627) | |||
SubClassOf(obo:CL_0000682 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0003929)) | |||
SubClassOf(obo:CL_0000682 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0004693)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. You could also consider classifying M cells as part of follicle associated epithelium rather than part of Peyer's patch epithelium (PMID: 18081850) but either terms would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeping as is as this was the change David requested
src/ontology/cl-edit.owl
Outdated
@@ -9457,7 +9457,7 @@ SubClassOf(obo:CL_0000676 obo:CL_0000378) | |||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "JB:jb") obo:IAO_0000115 obo:CL_0000677 "Cell of the intestinal epithelium with a brush border made up of many parallel packed microvilli; associated with absorption, particularly of macromolecules.") | |||
AnnotationAssertion(rdfs:label obo:CL_0000677 "gut absorptive cell") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see any changes to FAE (follicle associated enterocyte) - I believe it should be EquivalentTo enterocyte and part of some follicle associated epithelium. The uberon term will need to be imported into CL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed with @JABelfiore, part of
some follicle associated epithelium will be added as a subclass to follicle associated epithelium enterocyte.
src/ontology/cl-edit.owl
Outdated
@@ -9457,7 +9457,7 @@ SubClassOf(obo:CL_0000676 obo:CL_0000378) | |||
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "JB:jb") obo:IAO_0000115 obo:CL_0000677 "Cell of the intestinal epithelium with a brush border made up of many parallel packed microvilli; associated with absorption, particularly of macromolecules.") | |||
AnnotationAssertion(rdfs:label obo:CL_0000677 "gut absorptive cell") | |||
SubClassOf(obo:CL_0000677 obo:CL_0000000) | |||
SubClassOf(obo:CL_0000677 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0001277)) | |||
SubClassOf(obo:CL_0000677 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0004693)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gut absorptive cell is a grouping term for all enterocytes so it is not restricted to Peyer's patch epithelium (UBERON_0004693). I suggest changing it back to being part of intestinal epithelium (UBERON_0001277).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated as suggested
'part of' some 'intestinal epithelium'
#gogoeditdiff |
both made part of peyer's patch epithelium