Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M cell and FAE partonomy update #2897

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JABelfiore
Copy link
Collaborator

both made part of peyer's patch epithelium

@JABelfiore JABelfiore self-assigned this Jan 10, 2025
@JABelfiore JABelfiore linked an issue Jan 10, 2025 that may be closed by this pull request
@Caroline-99
Copy link
Collaborator

#gogoeditdiff

Copy link

github-actions bot commented Jan 13, 2025

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-01-14/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-master.owl/cl-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-01-14/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-pr.owl/cl-base.owl

Ontology imports

Ontology annotations

M cell of gut http://purl.obolibrary.org/obo/CL_0000682

Removed

Added

PR_000003490 http://purl.obolibrary.org/obo/PR_000003490

Removed

UBERON_0004693 http://purl.obolibrary.org/obo/UBERON_0004693

Added

granzyme H-associated CD8 T cell http://purl.obolibrary.org/obo/CL_4052032

Removed

Copy link

github-actions bot commented Jan 13, 2025

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

M cell of gut http://purl.obolibrary.org/obo/CL_0000682

Removed

Added

PR_000003490 http://purl.obolibrary.org/obo/PR_000003490

Removed

granzyme H-associated CD8 T cell http://purl.obolibrary.org/obo/CL_4052032

Removed

@@ -9506,7 +9506,7 @@ AnnotationAssertion(rdfs:label obo:CL_0000682 "M cell of gut")
SubClassOf(obo:CL_0000682 obo:CL_0000066)
SubClassOf(obo:CL_0000682 obo:CL_0000473)
SubClassOf(obo:CL_0000682 obo:CL_0000627)
SubClassOf(obo:CL_0000682 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0003929))
SubClassOf(obo:CL_0000682 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0004693))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. You could also consider classifying M cells as part of follicle associated epithelium rather than part of Peyer's patch epithelium (PMID: 18081850) but either terms would work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeping as is as this was the change David requested

@@ -9457,7 +9457,7 @@ SubClassOf(obo:CL_0000676 obo:CL_0000378)
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "JB:jb") obo:IAO_0000115 obo:CL_0000677 "Cell of the intestinal epithelium with a brush border made up of many parallel packed microvilli; associated with absorption, particularly of macromolecules.")
AnnotationAssertion(rdfs:label obo:CL_0000677 "gut absorptive cell")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see any changes to FAE (follicle associated enterocyte) - I believe it should be EquivalentTo enterocyte and part of some follicle associated epithelium. The uberon term will need to be imported into CL.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAE has the anonymous ancestor part of some peyer's patch epithelium which is the edit requested
Screenshot 2025-01-13 at 14 30 06

Copy link
Collaborator

@Caroline-99 Caroline-99 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed with @JABelfiore, part of some follicle associated epithelium will be added as a subclass to follicle associated epithelium enterocyte.

@@ -9457,7 +9457,7 @@ SubClassOf(obo:CL_0000676 obo:CL_0000378)
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "JB:jb") obo:IAO_0000115 obo:CL_0000677 "Cell of the intestinal epithelium with a brush border made up of many parallel packed microvilli; associated with absorption, particularly of macromolecules.")
AnnotationAssertion(rdfs:label obo:CL_0000677 "gut absorptive cell")
SubClassOf(obo:CL_0000677 obo:CL_0000000)
SubClassOf(obo:CL_0000677 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0001277))
SubClassOf(obo:CL_0000677 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0004693))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gut absorptive cell is a grouping term for all enterocytes so it is not restricted to Peyer's patch epithelium (UBERON_0004693). I suggest changing it back to being part of intestinal epithelium (UBERON_0001277).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated as suggested

@dosumis
Copy link
Contributor

dosumis commented Jan 14, 2025

#gogoeditdiff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M cell should be part of Peyer's patch epithelium
3 participants