-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Nushell Book with copy-able examples. #1692
Conversation
As per @NotTheDr01ds comment in the issue, I'm keeping any instance of the prompt where it's explicitly called out as part of the example. |
Noticed that there was still a page in both Spanish and Portuguese for the deprecated |
Wow! Thank you for this cleanup! I've caught a few things that the search/replace didn't quite seem to handle quite right. Unfortunately, I could only review up to about halfway through the Spanish book before my browser crashed due to (I'm guessing) the length. We might need to split PRs like this up into smaller chunks :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review comments might not have appeared last night because of the browser crash. Resubmitting.
Co-authored-by: Douglas <[email protected]>
Co-authored-by: Douglas <[email protected]>
Co-authored-by: Douglas <[email protected]>
Co-authored-by: Douglas <[email protected]>
@NotTheDr01ds Indentation's been fixed; the "When does |
Thanks! Merged! (Again) Great cleanup! |
Based on Issue #1684. I've left two sections in the book unchanged pending additional comments:
how_nushell_gets_run.md
- the REPL section specifically calls out the prompt indicator>
.overlays.md
- Lines 63-66 specifically call out the indicator and the overlay prefix.In some cases, I added the
# =>
prefix to example outputs that were not attached to a command example with a>
prefix to maintain consistency across examples, unless the example output was presented in isolation. However, I may have missed some instances.