Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113-T15-3] Module Manager #27

Open
wants to merge 488 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 208 commits
Commits
Show all changes
488 commits
Select commit Hold shift + click to select a range
0170c29
Fix a bug in CAP (will get a wrong CAP if involves S/U)
RenzoTsai Apr 3, 2020
81304ed
Merge pull request #114 from RenzoTsai/Fix_Bugs
DeetoMok Apr 3, 2020
fa6ba33
fixed bugs like creating exception for unacceptable values for modula…
Apr 3, 2020
6b1bce3
added ClearCommand and fixed code to make module codes and grades upp…
Apr 3, 2020
0bf12df
fixed for checkstyle
Apr 3, 2020
26fa797
fixed bug for when view commands are executed even when the wrong for…
Apr 3, 2020
718cad7
Update code to support showing preReqs which are not in available mod…
RenzoTsai Apr 3, 2020
190ca37
Fix some code style bugs
RenzoTsai Apr 3, 2020
0ef6b95
added Ui message when module plan is empty
Apr 3, 2020
00609ad
remove checkstyle error
Apr 3, 2020
125a609
Fix a bug when add the same modules to available modules list
RenzoTsai Apr 3, 2020
908275f
Updated Developer Guide
Apr 3, 2020
8f50541
Updated Developer Guide
Apr 3, 2020
0e3657a
Updated Developer Guide
Apr 3, 2020
408ec27
Merge pull request #117 from DeetoMok/master
DeetoMok Apr 3, 2020
deab1ff
Merge pull request #116 from RenzoTsai/Fix_Bugs
DeetoMok Apr 4, 2020
93f5cb6
Updated Developer Guide and Architecture.png
Apr 4, 2020
73e7d9d
Merge pull request #118 from DeetoMok/master
DeetoMok Apr 4, 2020
bcb9569
Added object diagram for logic component and Object_Diagram_of_Logic_…
Apr 4, 2020
caa1895
Updated object diagram for logic component and Object_Diagram_of_Logi…
Apr 4, 2020
20515d9
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
bennychanya Apr 4, 2020
fdd446d
Uploaded Class_Diagram_of_Model_Component.png
Apr 4, 2020
c856e6f
Merge pull request #119 from DeetoMok/master
DeetoMok Apr 4, 2020
4a618ad
Updated Developer Guide
Apr 4, 2020
ae4bcac
Merge pull request #120 from DeetoMok/master
DeetoMok Apr 4, 2020
d398f57
Updated Developer Guide and renamed AddToDataCommand.java to AddToAva…
Apr 5, 2020
400beb6
Fixed a delete bug (could not delete module when uppercase letter and…
Apr 5, 2020
85ac194
Fixed a add module bug (module added did not convert lowercase module…
Apr 5, 2020
04695c1
fixed bug (could not delete module in available module list if only d…
Apr 5, 2020
027a219
updated DG
Apr 5, 2020
955d219
Merge pull request #115 from DeetoMok/FixBug
DeetoMok Apr 5, 2020
0e0d60b
updated UI HELP String
Apr 5, 2020
3dad101
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
Apr 5, 2020
3af0ce0
reduce checkstyle error
Apr 5, 2020
bb9146f
Show "Please input your command:"
RenzoTsai Apr 5, 2020
b3d3a8d
Update text-ui-test
RenzoTsai Apr 5, 2020
db6a2bf
Merge pull request #121 from DeetoMok/master
RenzoTsai Apr 5, 2020
09ae766
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp …
RenzoTsai Apr 5, 2020
a741379
Update UG
RenzoTsai Apr 5, 2020
dbdb4bd
Merge pull request #122 from RenzoTsai/Fix_Bugs
RenzoTsai Apr 5, 2020
7195564
Fix a output error.
RenzoTsai Apr 5, 2020
92021ec
Fix a output error
RenzoTsai Apr 5, 2020
b524437
Merge pull request #123 from RenzoTsai/master
RenzoTsai Apr 5, 2020
5694e89
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 5, 2020
96857ee
Add Sequence Diagrams for DG
tzzzening Apr 6, 2020
c550b68
Update Sequence Diagrams in DG
tzzzening Apr 6, 2020
721225b
Edit sequence diagram for DeleteFromSem
tzzzening Apr 6, 2020
d11c43b
Add description for DeleteFromAvailableCommand
tzzzening Apr 6, 2020
7b2382c
Edit minor text
tzzzening Apr 6, 2020
bcd849f
Make minor changes to AvailableModulesList
tzzzening Apr 7, 2020
2d2d8c2
Update Runze's PPP
RenzoTsai Apr 7, 2020
aea7a3a
Merge pull request #125 from RenzoTsai/Runze-PPP
RenzoTsai Apr 7, 2020
b824311
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 7, 2020
896ff6a
Add chengtzening_PPP
tzzzening Apr 8, 2020
d182711
added JUnitTest and some Javadoc
Apr 8, 2020
be584a4
reduced checkstyle error
Apr 8, 2020
2089eac
Merge pull request #127 from DeetoMok/JUnitTest
DeetoMok Apr 8, 2020
93b0c31
Merge pull request #126 from chengTzeNing/edit-tzening-PPP
RenzoTsai Apr 9, 2020
38ca6a9
Merge pull request #124 from chengTzeNing/edit-DG
RenzoTsai Apr 9, 2020
85ba26d
Fix bugs in DG's graph showing
RenzoTsai Apr 9, 2020
cc888e0
Merge pull request #128 from RenzoTsai/master
RenzoTsai Apr 9, 2020
daca90a
Update DG's graph
RenzoTsai Apr 9, 2020
e7abace
Merge pull request #129 from RenzoTsai/master
RenzoTsai Apr 9, 2020
2faf0d7
update
Apr 9, 2020
008e765
Fix some bugs
RenzoTsai Apr 9, 2020
f032022
Update storage in DG
RenzoTsai Apr 9, 2020
55aff35
Update DeveloperGuide.md
RenzoTsai Apr 9, 2020
5b07c38
Update renzotsai.md
RenzoTsai Apr 9, 2020
c7c8e75
Update renzotsai.md
RenzoTsai Apr 9, 2020
6a9e05a
Update renzotsai.md
RenzoTsai Apr 9, 2020
e4c81f5
Update renzotsai.md
RenzoTsai Apr 9, 2020
6655a44
Merge pull request #130 from RenzoTsai/UpdateDG_UG
RenzoTsai Apr 9, 2020
7536b43
Update UserGuide.md
RenzoTsai Apr 9, 2020
3dadbb3
Update PPP
RenzoTsai Apr 9, 2020
49285c7
Merge pull request #131 from RenzoTsai/UpdateDG_UG
RenzoTsai Apr 9, 2020
6542c3f
Update PPP
RenzoTsai Apr 9, 2020
9da4ab8
Merge pull request #132 from RenzoTsai/UpdateDG_UG
RenzoTsai Apr 9, 2020
ccc8e4e
update darylmok-PPP
Apr 9, 2020
2a6f3af
updated DeveloperGuide.md Manual Testing section
Apr 9, 2020
ff8aab7
added table of contents in DeveloperGuide.md
Apr 9, 2020
b9e22ac
updated UserGuide.md
Apr 9, 2020
ab4f107
update DeveloperGuide.md Table of Contents
DeetoMok Apr 9, 2020
5071319
Added table of contents in User Guide
DeetoMok Apr 9, 2020
41d2244
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
DeetoMok Apr 9, 2020
5375c00
Merge pull request #133 from DeetoMok/master
DeetoMok Apr 9, 2020
ddf9af7
updated PPP
DeetoMok Apr 9, 2020
fc95853
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 10, 2020
907ab8a
Update JavaDoc
RenzoTsai Apr 10, 2020
0b971c8
Merge pull request #134 from RenzoTsai/AddJavaDoc
RenzoTsai Apr 10, 2020
b1d78b2
Update UserGuide.md
RenzoTsai Apr 10, 2020
5480f51
Update UserGuide.md
RenzoTsai Apr 10, 2020
b7cd90e
Add Sequence Diagram for FindCommand
tzzzening Apr 10, 2020
29537de
Add FindCommand to DG
tzzzening Apr 10, 2020
0e1c0c8
Delete Sequence Diagram for DeleteFromSemCommand
tzzzening Apr 10, 2020
9846425
Delete this Sequence Diagram
tzzzening Apr 10, 2020
867a18c
Add updated Sequence Diagram for DeleteFromSemCommand
tzzzening Apr 10, 2020
5cef69d
Add DeleteFromSemCommand Sequence Diagram to DG
tzzzening Apr 10, 2020
7bbbb5e
added MarkAsDone Sequence Diagram
DeetoMok Apr 10, 2020
0f6ea1b
Merge pull request #135 from DeetoMok/master
DeetoMok Apr 10, 2020
11fd28d
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp …
DeetoMok Apr 10, 2020
340c403
Add FindCommand to content page for UG and DG
tzzzening Apr 10, 2020
0666a48
Merge branch 'master' into DG-and-UG
tzzzening Apr 10, 2020
7d604b8
Merge pull request #136 from chengTzeNing/DG-and-UG
tzzzening Apr 10, 2020
493e20c
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 10, 2020
5ec9631
Update DeveloperGuide.md
RenzoTsai Apr 10, 2020
e581509
updated TOC format
DeetoMok Apr 10, 2020
c9d45d7
Shorten PPP
tzzzening Apr 10, 2020
f2a9ac0
Merge pull request #4 from DeetoMok/master
tzzzening Apr 10, 2020
503a20b
Merge branch 'master' of https://github.com/chengTzeNing/tp
tzzzening Apr 10, 2020
33a3f93
Edit headings in PPP
tzzzening Apr 10, 2020
3d51e9a
Edit to make it visible in .md file
tzzzening Apr 10, 2020
9abf359
Merge pull request #137 from chengTzeNing/tzening-PPP
tzzzening Apr 10, 2020
42cbf2e
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 10, 2020
9bde3f7
updated deetomok.md
DeetoMok Apr 10, 2020
0a787f0
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
DeetoMok Apr 10, 2020
424a8d4
corrected format of TOC for UserGuide.md
DeetoMok Apr 10, 2020
5afefe6
Refactor out boolean condition
bennychanya Apr 10, 2020
eb30299
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
bennychanya Apr 10, 2020
c668cee
Merge branch 'master' of https://github.com/bennychanya/tp into Refac…
bennychanya Apr 10, 2020
4b84b15
Update AboutUS.md
tzzzening Apr 10, 2020
6bf25cc
Merge pull request #138 from chengTzeNing/add-picture
tzzzening Apr 10, 2020
1e35a83
Merge pull request #5 from DeetoMok/master
tzzzening Apr 10, 2020
d1f3733
updated deetomok.md
DeetoMok Apr 10, 2020
f868eb3
Merge branch 'darylmok-PPP'
DeetoMok Apr 10, 2020
18c99ce
Changed CalculateCap_UML_diagram
bennychanya Apr 10, 2020
72d9e4e
Refactor if-statement condition to be clearer
bennychanya Apr 10, 2020
282c237
Edited Check Method to allow Module to be added if user failed the se…
bennychanya Apr 10, 2020
e18305b
Added find in command summary of user guide
DeetoMok Apr 10, 2020
8f6305f
Edited Javadoc for markAsDoneCommand
bennychanya Apr 10, 2020
c07194d
Merge pull request #140 from DeetoMok/master
DeetoMok Apr 10, 2020
594ece5
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
bennychanya Apr 10, 2020
7a3684a
Merge branch 'master' of https://github.com/bennychanya/tp into Refac…
bennychanya Apr 10, 2020
de3cae4
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 10, 2020
1c4d4b6
Merge branch 'master' of https://github.com/chengTzeNing/tp
tzzzening Apr 10, 2020
35a0ba7
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
bennychanya Apr 10, 2020
4297b70
Edit FindCommand in Ui
tzzzening Apr 10, 2020
8ef90e8
Update EXPECTED.txt
RenzoTsai Apr 10, 2020
4829af4
Merge pull request #141 from chengTzeNing/random-edits-1
tzzzening Apr 10, 2020
6c8c1b0
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 10, 2020
08e4fb5
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
bennychanya Apr 10, 2020
7d7cb81
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
RenzoTsai Apr 10, 2020
cba7ed4
Merge branch 'master' of https://github.com/bennychanya/tp into Refac…
bennychanya Apr 10, 2020
11a75cf
Fix a bug in find
RenzoTsai Apr 10, 2020
1980bd4
Fix a code style error
RenzoTsai Apr 10, 2020
248dbe7
Merge pull request #143 from RenzoTsai/FixBugOfFind
RenzoTsai Apr 10, 2020
9b4b5a4
Merge branch 'RefactorCodeV2' of https://github.com/bennychanya/tp in…
RenzoTsai Apr 10, 2020
c26914d
Fix a bug
RenzoTsai Apr 10, 2020
bc5858f
Fixed Check method
bennychanya Apr 10, 2020
54fa9d3
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
bennychanya Apr 10, 2020
3b37591
Merge branch 'master' of https://github.com/bennychanya/tp into Refac…
bennychanya Apr 10, 2020
b511ab3
Merge branch 'RefactorCodeV2' of https://github.com/bennychanya/tp in…
RenzoTsai Apr 10, 2020
63e66d4
Fix a bug
RenzoTsai Apr 10, 2020
f8f976a
Update UG
RenzoTsai Apr 10, 2020
3ce4092
Fix a bug involves in view /cc delete and markAsDone
RenzoTsai Apr 11, 2020
bd7fe1e
Update data's file
RenzoTsai Apr 11, 2020
97f54b6
Update test
RenzoTsai Apr 11, 2020
b83fa0e
Update UG
RenzoTsai Apr 11, 2020
1b4781d
Update delete from semester list
RenzoTsai Apr 11, 2020
3fbaaf1
Edited Javadoc for CalculateCapCommand, DeleteFromSemCommand, FindCom…
bennychanya Apr 11, 2020
5694f77
Removed type from DeleteFromSem as it has no uses
bennychanya Apr 11, 2020
e63e3f5
Edited Javadoc to pass CLI
bennychanya Apr 11, 2020
08c74ef
Update UG
RenzoTsai Apr 11, 2020
f8d7761
Merge pull request #3 from RenzoTsai/Revise-Refactor-code-v2
bennychanya Apr 11, 2020
3c2faf4
Reserve changed to allow duplicate module if module has failed
bennychanya Apr 11, 2020
c2f0d3e
Merge branch 'RefactorCodeV2' of https://github.com/bennychanya/tp in…
bennychanya Apr 11, 2020
cc76c74
Edited code indentation to pass CLI test
bennychanya Apr 11, 2020
fa3ad4f
Merge pull request #144 from RenzoTsai/master
tzzzening Apr 11, 2020
ecb4f55
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
bennychanya Apr 11, 2020
565e97c
Merge Conflict
bennychanya Apr 11, 2020
a88fd52
Edit Expected.txt to passed CLI
bennychanya Apr 11, 2020
1856821
Edited AboutUs
bennychanya Apr 11, 2020
372fe13
Changed comparator "equals" to "equalsIgnorecase" within AddToSemComm…
bennychanya Apr 11, 2020
a5b3f6f
Update renzotsai.md
RenzoTsai Apr 11, 2020
e9dc9ab
Update renzotsai.md
RenzoTsai Apr 11, 2020
1db60bc
Merge pull request #139 from bennychanya/RefactorCodeV2
RenzoTsai Apr 11, 2020
196b61f
Merge branch 'master' of https://github.com/bennychanya/tp into Dupli…
bennychanya Apr 11, 2020
f360fc8
Fix a bug in text ui test
RenzoTsai Apr 11, 2020
87fb027
Merge pull request #145 from RenzoTsai/master
RenzoTsai Apr 11, 2020
39e3af1
Updated deetomok.md
DeetoMok Apr 11, 2020
f2e7e5d
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
DeetoMok Apr 11, 2020
3e477ab
Edit to decimalformat to display "0.00" if CAP = 0
bennychanya Apr 11, 2020
1cc9114
Added function to input placeholder module for failed module
bennychanya Apr 11, 2020
a9b7406
Merge branch 'Duplicate_Failed_Module' of https://github.com/bennycha…
RenzoTsai Apr 11, 2020
2221cde
Fix a bug when remark a module from A to F/SU
RenzoTsai Apr 11, 2020
756bd77
Update UG
RenzoTsai Apr 11, 2020
6cc7ebc
Edited UserGuide to include F or CU grade scenario
bennychanya Apr 11, 2020
747c7ef
Merge pull request #4 from RenzoTsai/Revise-Duplicate-failed-module
bennychanya Apr 11, 2020
4e13fe7
Update UG
RenzoTsai Apr 11, 2020
5435f97
Merge pull request #147 from RenzoTsai/Revise-UG
RenzoTsai Apr 11, 2020
5cd8846
Merge branch 'master' of https://github.com/bennychanya/tp into Dupli…
bennychanya Apr 11, 2020
e75ce05
Merge pull request #146 from bennychanya/Duplicate_Failed_Module
DeetoMok Apr 11, 2020
6694bf4
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
DeetoMok Apr 11, 2020
5b3f103
Updated UG for MarkAsDone
bennychanya Apr 11, 2020
c03266a
Fix a bug in clear
RenzoTsai Apr 11, 2020
83e1089
Merge pull request #148 from RenzoTsai/master
bennychanya Apr 11, 2020
9842665
Edited my own PPP
bennychanya Apr 11, 2020
1ddd461
Merge pull request #149 from bennychanya/Duplicate_Failed_Module
bennychanya Apr 11, 2020
b6e2b9d
Update comments in markAsDone
RenzoTsai Apr 11, 2020
db833e5
Minor edit to Benny's PPP
bennychanya Apr 11, 2020
9a4d560
created appendFailString method in MarkAsDoneCommand
DeetoMok Apr 11, 2020
a237fc8
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
DeetoMok Apr 11, 2020
039b46a
Merge pull request #151 from bennychanya/Duplicate_Failed_Module
bennychanya Apr 11, 2020
bd08610
Merge pull request #150 from RenzoTsai/master
bennychanya Apr 11, 2020
5c20c39
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
tzzzening Apr 11, 2020
c8eae23
updated MarkAsDone Sequence diagram, and added appendFailString method
DeetoMok Apr 11, 2020
be58310
Updated deetomok.md
DeetoMok Apr 11, 2020
f43aaa3
Merge branch 'master' into master
DeetoMok Apr 11, 2020
736bb36
Added Javadoc
DeetoMok Apr 11, 2020
f3c1a4f
updated clearer Mark_As_Done_Sequence_Diagram.png
DeetoMok Apr 11, 2020
0c9026b
Merge pull request #152 from DeetoMok/master
DeetoMok Apr 11, 2020
bb57209
removed unclear boolean variables
DeetoMok Apr 11, 2020
137a0d7
updated DG
DeetoMok Apr 11, 2020
8e0d375
update DG
DeetoMok Apr 11, 2020
200a0d1
Merge pull request #153 from DeetoMok/master
DeetoMok Apr 11, 2020
99f9c9d
Updated DG for Mark As Done Command
bennychanya Apr 11, 2020
1ababaa
updated readme and DG
DeetoMok Apr 11, 2020
f13a1c5
Merge pull request #155 from DeetoMok/master
DeetoMok Apr 11, 2020
cac7a97
Merge pull request #154 from bennychanya/master
bennychanya Apr 11, 2020
7ca372b
added viewing modules in DeveloperGuide.md
DeetoMok Apr 11, 2020
d6f5658
Update renzotsai.md
RenzoTsai Apr 11, 2020
44d5ae5
updated viewing modules in DeveloperGuide.md
DeetoMok Apr 11, 2020
1f66d9d
Merge branch 'master' of https://github.com/AY1920S2-CS2113-T15-3/tp
DeetoMok Apr 11, 2020
1cc7662
Updated DG with design consideration for Mark As Done
bennychanya Apr 11, 2020
a096b7d
updated deetomok.md
DeetoMok Apr 11, 2020
ee35a19
updated deetomok.md
DeetoMok Apr 11, 2020
c91c694
Merge pull request #157 from bennychanya/master
bennychanya Apr 11, 2020
173cc67
updated DG
DeetoMok Apr 11, 2020
e0354ab
Merge pull request #156 from DeetoMok/master
DeetoMok Apr 11, 2020
5a278a8
Update add to sem design consideration in DG
RenzoTsai Apr 11, 2020
356b020
Update Benny's PPP
bennychanya Apr 11, 2020
c999d0f
Update DG &PPP
RenzoTsai Apr 11, 2020
a301644
Add design considerations for AvailableModulesList
tzzzening Apr 11, 2020
5b26b55
Merge pull request #159 from bennychanya/master
bennychanya Apr 11, 2020
f44c54e
Merge branch 'master' into random-edits-2
tzzzening Apr 11, 2020
32a053c
Merge pull request #160 from chengTzeNing/random-edits-2
RenzoTsai Apr 11, 2020
ac20668
Merge pull request #158 from RenzoTsai/master
tzzzening Apr 11, 2020
bb44b1d
Added table for Design consideration
bennychanya Apr 11, 2020
35f7ebf
updated deetomok.md
DeetoMok Apr 11, 2020
5b53a42
Merge pull request #162 from DeetoMok/master
DeetoMok Apr 11, 2020
e3bc2a3
updated deetomok.md
DeetoMok Apr 11, 2020
ddca98e
Merge pull request #161 from bennychanya/master
bennychanya Apr 11, 2020
7275bd1
Merge pull request #163 from DeetoMok/master
DeetoMok Apr 11, 2020
496b1bb
update AboutUs.md
DeetoMok Apr 11, 2020
106868f
Merge pull request #164 from DeetoMok/master
DeetoMok Apr 11, 2020
3a11a9d
update deetomok.md
DeetoMok Apr 11, 2020
c7d20f3
Merge pull request #165 from DeetoMok/master
DeetoMok Apr 11, 2020
ce5211b
update deetomok.md
DeetoMok Apr 11, 2020
8ff3f7e
Merge pull request #166 from DeetoMok/master
DeetoMok Apr 11, 2020
5519f9b
update UG
DeetoMok Apr 11, 2020
c750dc1
Merge pull request #167 from DeetoMok/master
DeetoMok Apr 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ src/main/resources/docs/
*.iml
bin/

/text-ui-test/ACTUAL.txt
/text-ui-test/ACTUAL.txt
*.log
1 change: 1 addition & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ checkstyle {

run{
standardInput = System.in
enableAssertions = true
}
25 changes: 25 additions & 0 deletions data/availableModulesList.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
id,name,mc,prerequisites
CS1010,Programming Methodology,4,
CS2030,Programming Methodology II,4,CS1010
CS2040,Data Structures and Algorithms,4,CS1010
CS2100,Computer Organisation,4,CS1010
CS2106,Introduction to Operating Systems,4,CS2100
CS2113,Software Engineering & Object-Oriented Programming,4,CS2040
CS2105,Introduction to Computer Networks,4,CS2040
ES1000,Foundation Academic English,4,
ES1103,English for Academic Purposes,4,ES1000
CS2101,Effective Communication for Computing Professionals,4,
CS2102,Database Systems,4,CS2030 CS1231
CS2101,Effective Communication for Computing Professionals,4,
CS2102,Database Systems,4,CS2030 CS1231
GEH1001,Globalisation and New Media,4,
GEH1002,Economic Issues in Dev World,4,
GEH1004,Chinese Heritage: Hist & Lit,4,
GEQ1000,Asking Questions,4,
GER1000,Quantitative Reasoning,4,
GET1001,Seeing the World Through Maps,4,
GET1002,Bridging East and West: Exploring Chinese Communication,4,
GET1003,Home,4,
GES1000,Singapore Employment Law,4,
GES1002,Global EC Dimensions of S'pore,4,
GES1003,Changing Landscapes of Singapore,4,
1 change: 1 addition & 0 deletions data/personInfo.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
User,Y1
7 changes: 7 additions & 0 deletions data/semesterList.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
id,name,mc,semester,isDone,grade
cS1010,/,4,3,false,/
cs0000,/,3,4,false,/
CS0001,/,4,4,false,/
CS2113,Software Engineering & Object-Oriented Programming,4,4,false,/
cS1010,/,4,4,false,/
cs2113,/,4,5,false,/
8 changes: 4 additions & 4 deletions docs/AboutUs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

Display | Name | Github Profile | Portfolio
--------|:----:|:--------------:|:---------:
![](https://via.placeholder.com/100.png?text=Photo) | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![Cai Runze](https://via.placeholder.com/100.png?text=Photo) | Cai Runze | [Github](https://github.com/RenzoTsai) | [Portfolio](docs/team/johndoe.md)
![Daryl Mok](https://via.placeholder.com/100.png?text=Photo) | Daryl Mok| [Github](https://github.com/DeetoMok) | [Portfolio](docs/team/johndoe.md)
![Benny Chan](https://via.placeholder.com/100.png?text=Photo) | Benny Chan | [Github](https://github.com/bennychanya) | [Portfolio](docs/team/johndoe.md)
![Cheng Tze Ning](https://via.placeholder.com/100.png?text=Photo) | Cheng Tze Ning | [Github](https://github.com/chengTzeNing) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
154 changes: 146 additions & 8 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
@@ -1,34 +1,172 @@
# Developer Guide

## Design & Implementation

{Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}

### Architecture

![Architecture Diagram](https://github.com/DeetoMok/tp/raw/master/docs/images/Architecture.png)

The Architecture Diagram given above explains the high-level design of the Module Manager Application.

Module Manager consists of a main class called Duke responsible for
* At app launch: Initializes the components in the correct sequence, and connects them up with each other
* At shut down: Shuts down the components and invokes cleanup method where necessary

The other components involved are:

`UI`: The user interface of the application

`Storage`: Reads data from, and writes data to, the hard disk

#### UI component
The `UI` component consists of a `Ui` class that stores all user interaction output data.
It displays all user interactions to the user based on the command line inputs received.

The `UI` component,

* Executes user commands using the `Logic` component

#### Logic component
The `Logic` component

1. `Logic` uses the `Parser` class to parse the user command.
2. The parsed command is passed to `Controller` which then returns a specific command class
e.g. `AddCommand`, `FindCommand` etc. which is executed by the main class `Duke`.
All these command classes inherits from the abstract `Command` class.
3. The command execution can affect the Model (e.g. adding a module in ModuleList)
4. The result of the command execution is passed back to the Ui.
5. In addition, the command execution can also instruct the `Ui` to perform certain actions,
such as displaying help to the user.

#### Model component
The `Model` component
* Stores a `Person` object that represents the user's details. (e.g. `totalCap`, `totalModuleCreditCompleted`)
* Stores the `ModuleList` and `SemesterList` Data
* Does not depend on any of the other three components

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if Model component is not related to other three components, then how would a Person object, which is stored in Model Component, have their CAP calculated? Maybe "does not depend" is not the correct phrase here?


#### Storage component
The `Storage` component,
* can save `personInfo` objects in csv format and read it back
* can save the available module list in csv format and read it back
* can save the semester list in csv format and read it back


### Implementation

#### `Add to Semester` feature

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagram looks very neat and helps the developer understand the basic logic of add to semester future. So perhaps, is the explanation repetitive here?

The `Add to Semester` mechanism is facilitated by `AddtoSemCommand` which extends from `Command`.
It allows `ModuleManager` to assign a module to a semester by adding the module to a
`SemModulesList`, it implements the following operations:

Given below is an example how the `Add to Semester` behaves at each step.

##### Step 1:
The user launches the application for the first time. The `SemesterList` will be initialized with the none
`SemModulesList` in it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to say "empty SemModulesList"?


##### Step 2:
When users enter a add to semester command, e.g `add id/CS2113 s/4 mc/4`, this command will be parsed in `Parser`
and then `Parser` returns a `AddToSemCommand`. `AddToSemCommand` then calls `Command#execute(SemesterList semesterList,
AvailableModulesList availableModulesList) `
`(AddToSemCommand#execute(SemesterList semesterList, AvailableModulesList availableModulesList))`

##### Step 3:
`AddToSemCommand#execute()` then calls self method `AddToSemCommand#addModule()`.`AddToSemCommand#addModule()`
then calls `AddToSemCommand#checkModuleExist(semesterList)` to check whether the selected
RenzoTsai marked this conversation as resolved.
Show resolved Hide resolved
module is already in the selected module list (i.e:`semesterList`, which is a `PriorityQueue<SemModulesList>`).
If the module is not in the list, `AddToSemCommand#addModule()` will check whether there is a semester list
(i.e:`semesterModulesList`, which is a `ArrayList<SelectedModule>`) whose name is the module's semester name.
If the semester list exist, the module will be added to the list.
If not, `AddToSemCommand#addModule()` will create a new semester list and then add this module to the new list. and the
the new semester list will be added to `semesterList` as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this section quite confusing to read as there are a few variables and classes with similar names (semesterList, SemModulesList, semesterModulesList, SemesterList), and the multiple 'if' condition checks. Perhaps it would help to briefly explain the connection between semesterList and semesterModulesList, at the very beginning, before delving into the logic? I.e. "semesterList represents XXX and stores instances of SemModuleList. semesterModulesList represents XXX and stores XXX"


#### Step 4:
`AddToSemCommand#execute()` calls `Ui.showAddedToSemMessage(selectedModule.announceAdded())` to show the result to the
user

The following sequence diagram shows how the `Add to Semester` operation works:
![Sequence Diagram of Add to Semester](https://github.com/RenzoTsai/tp/blob/Update_DG/docs/UML%20img%20folder/Sequence%20Diagram%20of%20Add%20to%20Semester.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the sequence diagram
Screenshot_4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, the diagram doesn't show up properly when I load the website, and stays like this when I refresh. I had to right click the icon and open in a new tab to view it. Could there be a problem with the file linking?
Screenshot_1



#### Calculate CAP feature

The Calculate CAP mechanism is executed by `CalculateCapCommand`.
`CalculateCapCommand` is extended from `Command` and this implementation calculates the CAP using completed
`SelectedModule` stored in `SemModulesList`.

Given below is the behaviour of the Calculate CAP mechanism at each step:

Step 1:
User launches the application. `SelectedModules` are added to `SemModuleList` through either of the following methods:
1) Imported from `semesterList.csv` using `StorageSemesterList.load()`
2) Added using `add id/ID s/SEMESTER mc/MODULE_CREDIT` command

Step 2:
User executes `CAP` command to view his own CAP. The `CAP` commands is parsed through `Parser`, which would then return

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2020-03-30 at 5 16 42 PM
Some remarks to the Calculate CAP operation sequence diagram.

`CalculateCapCommand()`. `CalculateCapCommand.execute()` is then called.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-03-31 at 14 50 32

I am wondering if it is fully clear weather object representing CalculateCapCommand class or a Person Object Calculates the total cap. More specifically, the setTotalCap() method and getTotalCap() methods are pointed in the same direction, so I wasn't a 100% sure from the diagram where the CAP calculation was happening.


Step 3:
`CalculateCapCommand.execute()` will call `CalculateCapCommand.calculateCap(SemesterList semesterList)`, which will
calculate CAP by looking for all the completed `SelectedModules` stored within `SemModuleList`, which are stored within
`SemesterList`. It will then assign a `double` type ranging from 0.00 to 5.00 to `Person.totalCap`.

Step 4:
After the CAP is assigned to `Person.totalCap`, `Person.totalCap` is then called and formatted using `DecimalFormat` into a `String`
with a pattern of `#.00`. `Ui.showcap(cap)` is called to display the user's cap using the formatted `String`.

The following diagram shows how the Calculate CAP operation works:
![Calculate CAP feature](https://github.com/bennychanya/tp/blob/master/CalculateCap.png?raw=true)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with what Isabella said about the construction of CalculateCapCommand. Otherwise it looks good to me. Perhaps you may want to specify the return value (grade) of the getGrade() method to be consistent, as you did so for totalCap?



#####



## Product Scope
### Target user profile

{Describe the target user profile}
* A computer science undergraduate of NUS with a need to manage modules
* Prefer desktop apps over other types
* Able to type quickly
* Prefers to control apps with typing rather than a mouse
* Comfortable using Command Line Input apps

### Value proposition

{Describe the value proposition: what problem does it solve?}
Manage and plan modules quickly with CLI, faster than a mouse or GUI driven app

## User Stories

|Version| As a ... | I want to ... | So that I can ...|
|Priority| As a ... | I want to ... | So that I can ...|
|--------|----------|---------------|------------------|
|v1.0|new user|see usage instructions|refer to them when I forget how to use the application|
|v2.0|user|find a to-do item by name|locate a to-do without having to go through the entire list|
|***|User|View my study plan|Keep track of what is my study plan when I forget about it|
|***|User|Add and assign modules to different semesters|Update my study plan|
|***|User|Add modules to available module list|Add the module to my study plan when I plan to in the future|
|***|User|Delete study plans in specific semesters|Update my study plan according to my new plan in mind|
|***|New user|see usage instructions|Refer to instructions when I forgot how to use the App|
|***|User|Mark module as done|Update my study plan according to modules that I have completed|
|**|User|Calculate cap|Check my current cap based on modules I have completed|
|**|User|find a module by name or module code|Locate a module and its module code without having to go through all the modules|


## Non-Functional Requirements

{Give non-functional requirements}
1. Should work on any mainstream OS as long as it has Java `11` or above installed.
2. Should be able to hold up to 1000 modules in the available module list without a noticeable sluggishness in
performance for typical usage.
3. A user with above average typing speed for regular English text (i.e. not code, not system admin commands)
should be able to accomplish most of the tasks faster using commands than using the mouse.


## Glossary

* *glossary item* - Definition
**Mainstream OS** - Windows, Linux, Unix, OS-X



## Instructions for Manual Testing

{Give instructions on how to do a manual product testing e.g., how to load sample data to be used for testing}


2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@

Useful links:
* [User Guide](UserGuide.md)
* [Developer Guide](UserGuide.md)
* [Developer Guide](DeveloperGuide.md)
* [About Us](AboutUs.md)
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/UML reference sheet.pptx
Binary file not shown.
Loading