[Lam Yue Wei] iP #57
Open
[Lam Yue Wei] iP #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katelo731
reviewed
Feb 4, 2020
There was a problem hiding this comment.
Overall, the code is easy to read. Hope these reviews can improve your code!
[Also took part in this review: @alaukiknpant ]
src/main/java/Duke.java
Outdated
|
|
||
| public class Duke { | ||
| public static void main(String[] args) { | ||
| Task[] tasks = new Task[100]; | ||
| int count = 1; | ||
| int count = 0; | ||
| boolean isBye = false; | ||
| System.out.println(" ____________________________________________________________"); |
There was a problem hiding this comment.
Maybe we can apply refactoring to the greeting function.
src/main/java/Duke.java
Outdated
| System.out.println(" ____________________________________________________________"); | ||
| String[] stringSplit = string.split(" "); | ||
| if (string.equals("list")) { | ||
| switch (stringSplit[0]) { |
There was a problem hiding this comment.
Use switch to deal with different types of commands is more clear than my method. Nice!
src/main/java/Duke.java
Outdated
|
|
||
| public class Duke { | ||
| public static void main(String[] args) { | ||
| Task[] tasks = new Task[100]; | ||
| int count = 1; | ||
| int count = 0; |
There was a problem hiding this comment.
Maybe we should use 'taskCount' to refer to the total number of tasks.
…as made changes according to the feedbacks given
…ine, event, default. Updated input and expected file
…than accessing the Task's isDone property
…s and structured by including corner cases
Complete Level 9 Find, Modify runtest.bat to delete duke.txt in text-…
Pull Request from Branch-A-JavaDoc to Master
Pull Request from branch-Level-8 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.