Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T09-2] BookKeeper #32

Open
wants to merge 471 commits into
base: master
Choose a base branch
from

Conversation

rertyy
Copy link

@rertyy rertyy commented Feb 19, 2024

Our target users are small business owners that sell flower bouquets items who are looking for efficient ways to manage their customer lists and streamline their customer management processes and orders. It is optimized for CLI users so that these processes can be done efficiently and reliably.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 72.55521% with 174 lines in your changes are missing coverage. Please review.

Project coverage is 74.31%. Comparing base (1e9a7e2) to head (893c675).

Files Patch % Lines
...ddress/logic/commands/orders/EditOrderCommand.java 30.20% 65 Missing and 2 partials ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 17 Missing ⚠️
src/main/java/seedu/address/ui/OrderListPanel.java 0.00% 12 Missing ⚠️
...n/java/seedu/address/storage/JsonAdaptedOrder.java 78.00% 10 Missing and 1 partial ⚠️
src/main/java/seedu/address/ui/OrderCard.java 0.00% 11 Missing ⚠️
src/main/java/seedu/address/model/AddressBook.java 25.00% 9 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 52.63% 9 Missing ⚠️
...a/seedu/address/model/person/UniquePersonList.java 75.86% 7 Missing ⚠️
...u/address/logic/parser/EditOrderCommandParser.java 68.42% 2 Missing and 4 partials ⚠️
...ress/logic/commands/orders/DeleteOrderCommand.java 86.20% 1 Missing and 3 partials ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
- Coverage     75.26%   74.31%   -0.95%     
- Complexity      419      571     +152     
============================================
  Files            71       92      +21     
  Lines          1338     1927     +589     
  Branches        126      190      +64     
============================================
+ Hits           1007     1432     +425     
- Misses          301      447     +146     
- Partials         30       48      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rertyy and others added 29 commits March 29, 2024 08:43
Website header and HelpWindow point to se-edu base repo rather than our
repository. Links have been changed accordingly.
…List"

This reverts commit 3930db7, reversing
changes made to 8eca76e.
Instead of using Pair<<Person, Order>> everywhere, use
circular references. Person -> Order -> Person -> ...
This allows for simpler code logic.

TODO:
Check if circular references are a problem. From preliminary testing,
add and delete do not appear to have problems.
Now that Order has a reference to Person, new tests are required to test
 that the Person reference functions as expected.
Missing tests for newly added methods.
Include more tests for setPersonsAndAddOrder and
setPersonsAndDeleteOrder.
Include test case for EditOrderCommand.
The UserGuide is not up to date with our latest implementations.

This may confuse the user when going through the UserGuide.

Update the UserGuide with our new features.

This will ensure the User will have the knowledge to use these
respective commands.
The orders are not sorted chronologically.

This may confuse users or make the application hard for them to check
for deadline.

Add sort command whenever an Order is added.

This will ensure the entire Order list stays sorted.
The test case was insufficient and the codes do not adhere to SLAP.

This may cause future development to be poor due to lacking essential
test cases or inaccurate performing methods.

Fix the weak SLAP and add test case.

This will aid in future development by being creating a strong
code foundation.
When the list is empty, the background color will reset to white, the
default color.

This is ugly and not the intended outcome of our application.

Add a default color for background when the list is empty.

This is more pleasant to the user's eyes, and will allow our
application to look better.
Updating new puml diagram in DG.md
The main feature is out of date.

Users may not understand how to use the application.

Update the UserGuide with the new order features.

This will ensure that users can use the application with the latest
updates to reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants