-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103T-T09-2] BookKeeper #32
Open
rertyy
wants to merge
471
commits into
nus-cs2103-AY2324S2:master
Choose a base branch
from
AY2324S2-CS2103T-T09-2:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103T-T09-2] BookKeeper #32
rertyy
wants to merge
471
commits into
nus-cs2103-AY2324S2:master
from
AY2324S2-CS2103T-T09-2:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Website header and HelpWindow point to se-edu base repo rather than our repository. Links have been changed accordingly.
Instead of using Pair<<Person, Order>> everywhere, use circular references. Person -> Order -> Person -> ... This allows for simpler code logic. TODO: Check if circular references are a problem. From preliminary testing, add and delete do not appear to have problems.
Now that Order has a reference to Person, new tests are required to test that the Person reference functions as expected.
Use Person reference in Order
Missing tests for newly added methods.
Include more tests for setPersonsAndAddOrder and setPersonsAndDeleteOrder.
Include test case for EditOrderCommand.
Update UserGuide.md
Add deleteOrder command to UG
Modify links to point to repo
Updating UG.md
The UserGuide is not up to date with our latest implementations. This may confuse the user when going through the UserGuide. Update the UserGuide with our new features. This will ensure the User will have the knowledge to use these respective commands.
Update the UserGuide
The orders are not sorted chronologically. This may confuse users or make the application hard for them to check for deadline. Add sort command whenever an Order is added. This will ensure the entire Order list stays sorted.
The test case was insufficient and the codes do not adhere to SLAP. This may cause future development to be poor due to lacking essential test cases or inaccurate performing methods. Fix the weak SLAP and add test case. This will aid in future development by being creating a strong code foundation.
When the list is empty, the background color will reset to white, the default color. This is ugly and not the intended outcome of our application. Add a default color for background when the list is empty. This is more pleasant to the user's eyes, and will allow our application to look better.
Updating new puml diagram in DG.md
The main feature is out of date. Users may not understand how to use the application. Update the UserGuide with the new order features. This will ensure that users can use the application with the latest updates to reference.
Fix broken images
Edited the planned feature enhancement information in DG
Branch update developer guide
Last min changes
fix DeveloperGuide
Fix number parse tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our target users are small business owners that sell flower bouquets items who are looking for efficient ways to manage their customer lists and streamline their customer management processes and orders. It is optimized for CLI users so that these processes can be done efficiently and reliably.