Skip to content

Commit

Permalink
Merge pull request #184 from teojunda/master
Browse files Browse the repository at this point in the history
Update images in UG
  • Loading branch information
teojunda authored Apr 12, 2024
2 parents 0b8735d + 7b8b3f7 commit b4e503a
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 4 deletions.
4 changes: 2 additions & 2 deletions docs/UserGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -323,9 +323,9 @@ Format: `view INDEX`
* `INDEX` **must be a positive integer** 1, 2, 3, …​

Examples:
* `view 1` views the 2nd person of the displayed person list on the side panel display.
* `view 1` views the 1st person of the displayed person list on the side panel display.

![result for 'view 2'](images/view_example.png)
![result for 'view 1'](images/view_example.png)

### Adding note to a person : `an`

Expand Down
Binary file modified docs/images/ActualUi.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/InterfaceWalkthrough.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/ac_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/an_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/find_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/uc_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/view_example.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 5 additions & 2 deletions docs/team/teojunda.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ TaToolkit is a desktop application used for teaching assistants to manage their
* Continuous Integration/ Continuous Delivery
* Git Version Control


Given below are my contributions to the project.

* **Modified Feature**: Changed the `editCommand` to suit the purposes of TA Toolkit better.
Expand All @@ -26,6 +25,7 @@ Given below are my contributions to the project.
* Solution: I leveraged design patterns that were already familiar within the framework, such as Command and Observer patterns, ensuring that the enhancements were both effective and minimally invasive. This approach allowed for a smoother integration and improved maintainability.
* Credits: The code was part of an existing feature from the AB3 brownfield project.

<br>

* **New Feature**: Added a `deleteNoteCommand` to delete notes from a student contact.
* What it does: allows the user to delete notes from a student contact.
Expand All @@ -36,19 +36,21 @@ Given below are my contributions to the project.
* Design Challenge: The feature had to be designed in a way that it complemented the existing command structure and did not introduce bugs or usability issues.
* Solution: I adopted a modular design approach, allowing the deleteNoteCommand to function independently yet cohesively within the system’s broader framework. This was achieved by encapsulating the command logic and ensuring it adhered to the principles of high cohesion and low coupling, thus enhancing the maintainability and scalability of the codebase.

<br>

* **Code contributed**: [RepoSense link](https://nus-cs2103-ay2324s2.github.io/tp-dashboard/?search=f14&sort=groupTitle&sortWithin=title&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code~other&since=2024-02-23&tabOpen=true&tabType=authorship&tabAuthor=teojunda&tabRepo=AY2324S2-CS2103T-F14-3%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=docs~functional-code~test-code&authorshipIsBinaryFileTypeChecked=false&authorshipIsIgnoredFilesChecked=false)


* **Project management**:
* Integrated CodeCov into project repository
* Set up MarkBind project website

<br>

* **Other enhancements**:
* Implemented sorted order of contacts in TA Toolkit (Pull request [\#43](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/43))
* Ensured side panel display would correct update after every relevant command (Pull request [\#65](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/65/files))

<br>

* **Documentation**:
* User Guide:
Expand All @@ -58,6 +60,7 @@ Given below are my contributions to the project.
* Added use cases and user stories (Pull requests [\#30](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/30), [\#37](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/37))
* Included implementation details of Edit Command (Pull request [\#57](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/57))

<br>

* **Community**:
* 36 PRs reviewed (examples: [\#38](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/38), [\#55](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/55), [\#112](https://github.com/AY2324S2-CS2103T-F14-3/tp/pull/112))
Expand Down

0 comments on commit b4e503a

Please sign in to comment.