Skip to content

Commit

Permalink
Fix find command screenshot (#224)
Browse files Browse the repository at this point in the history
* Fix find command screenshot

* make CCA required

* fix many bugs

* last fixes
  • Loading branch information
Fidget-Spinner authored Apr 15, 2024
1 parent bf46578 commit 9e9a33f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions docs/UserGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,6 @@ $$
\quad
\underset{
\substack{
\text{\color{red}{Optional}} \\
\text{\color{red}{can have multiple}}
}
}{
Expand All @@ -450,12 +449,12 @@ The people who will be listed are people who are:
##### Examples:

* `filter c/NUS Cycling`
* `filter c/NUS Cycling r/classmates`
* `filter c/NUS Cycling r/classmates r/colleagues`
* `filter c/NUS Cycling r/Logistics`
* `filter c/NUS Cycling r/Logistics r/Outreach`

##### Outcome:

For `filter c/NUS Cycling r/classmates r/colleagues`:
For `filter c/NUS Cycling r/Logistics r/Outreach`:
<center>
<img width="700px" src="images/UG-Basics/filter-output-1.png">
</center>
Expand Down Expand Up @@ -565,7 +564,6 @@ $$

* `add n/John Doe p/98765432 e/[email protected] a/6 Sin Ming #01-01`
* `add n/John Doe p/98765432 e/[email protected] a/6 Sin Ming #01-01 c/NUS Cycling c/NUS Origami`
* `add n/John Doe p/98765432 e/[email protected] a/6 Sin Ming #01-01 r/Treasurer r/Logistics`
* `add n/John Doe p/98765432 e/[email protected] a/6 Sin Ming #01-01 d/Manages money`

##### Outcome:
Expand Down Expand Up @@ -721,7 +719,7 @@ Roles.
Suppose we start with this list of people displayed in the **Results Box**.

<center>
<img src="images/editcommandoutcome1.png" >
<img src="images/listcommandoutcome.png" >
</center>

We then run the following command:
Expand Down Expand Up @@ -799,7 +797,7 @@ For `assign 1 r/Treasurer`
##### Possible Failures:

- The [_Index of person_](#glossary) must be within range. For example, it must be greater than 0, and smaller than the length of the currently displayed list of people. This is because the [_Index of person_](#glossary) will be used to indicate which person to operate the command on.
- If the CCA is `nil` (for instance, the command you ran is `assign 1 r/nil`), the command will error out.
- If the Role is `nil` (for instance, the command you ran is `assign 1 r/nil`), the command will error out.

<box type="tip"><md>
**Tip**: If you intend to remove all roles for a person, try running `edit <index of person> r/nil`, (see the [`edit` command](#editing-a-person-edit)).
Expand Down Expand Up @@ -1011,7 +1009,7 @@ This is because a person without a CCA should not have any roles.

Suppose we start with this list of people displayed in the **Results Box**.

<img src="images/UG-Basics/outcomeCca_deleteBefore.png" >
<img src="images/listcommandoutcome.png" >

We then run the following command:

Expand All @@ -1021,7 +1019,7 @@ cca_delete c/NUS Cycling

<img src="images/UG-Basics/outcomeCca_deleteAfter1.png" >

Notice that the CCA of the person `Caleb Hugh` has been removed.
Notice that the CCA of the people in our list has been removed.

##### Possible Failures:

Expand Down
Binary file modified docs/images/UG-Basics/filter-output-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/UG-Basics/find-output-1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/UG-Basics/outcomeCca_deleteAfter1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/editcommandoutcome2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/listcommandoutcome.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 9e9a33f

Please sign in to comment.