Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-client): Change auth_map type to Object type. #485

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

IscoRuta98
Copy link
Contributor

@IscoRuta98 IscoRuta98 commented Dec 14, 2022

Aim: Correctly save user's security answers in the enclave.

Description

  • With the current implementation, the user's answers to security questions are not saved correctly as the JavaScript message pack library does not seem to support ES6 Maps. More details of this issue can be found on this link.
  • To fix this issue, the auth_map's type is converted (from a Map<string, string> type) to a Object type.

@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for nautilus-wallet-staging ready!

Name Link
🔨 Latest commit 6a63409
🔍 Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/639ac492e0dd640008ee3299
😎 Deploy Preview https://deploy-preview-485--nautilus-wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #485 (6a63409) into main (30822c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   49.18%   49.18%           
=======================================
  Files         147      147           
  Lines        2324     2324           
  Branches      457      457           
=======================================
  Hits         1143     1143           
  Misses       1181     1181           
Impacted Files Coverage Δ
web-client/src/app/state/session.service.ts 6.79% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@IscoRuta98 IscoRuta98 marked this pull request as ready for review December 14, 2022 12:17
@billguo99
Copy link
Contributor

Have you tested this change locally to check that this change works?

@IscoRuta98 IscoRuta98 merged commit f466945 into main Dec 15, 2022
@IscoRuta98 IscoRuta98 deleted the fix-auth-map-type branch December 15, 2022 07:16
sonasi added a commit that referenced this pull request Jan 6, 2023
* refactor(backend/tests): remove superfluous mocks (#473)

* refactor(backend): use odmantic engine (#479)

* rename(backend/setting): maximum list length

* feat(backend): improve `GET` endpoint semantics

The endpoint should receive the `wallet_id` as a query parameter and
return the internal mongodb document id.

* chore(backend): remove dead code

* refactor(backend): use odmantic engine

* fix(web-client): add issuers for servers (#482)

* fix(web-client): add issuers for servers

* Update web-client/src/environments/environment.palau-prod.ts

Co-authored-by: Jean-Pierre de Villiers <[email protected]>

Co-authored-by: Jean-Pierre de Villiers <[email protected]>

* feat(web-client): Pull payment flag (#486)

* feat(web-client): Add hidePullPayment flag.

* style(web-client): run prettier

* fix(web-client): Fix ESLint error.

* style(web-client): run prettier

* fix(web-client): Change auth_map type to Object type. (#485)

* fix(web-client): Change auth_map type to Object type.

* fix(web-client): Fix ESLint error.

* feat(web-client): add auto logout (#481)

* feat(web-client): add auto logout

* feat(web-client): add ngZone for auto logout

* refactor(web-client): remove redundant isLogin variable in auto logout

* refactor(web-client): move auto logout to app component

* refactor(web-client): remove autoLogOutService from logout-button

* refactor(web-client): remove console log line in auto-logout service

* feat(web-client): add environment flag for auto logout

* fix(web-client): initialize localStorage lastAction for auto logout first

* fix(web-client): pull payment minor text fixes (#491)

* fix(cors): allow `localhost:4200` on staging (#492)

* feat(web-client): bookmark management (#451)

* fix(web-client): Update Pin Entry text for pull payment. (#497)

* fix(web-client): Update Pin Entry text for pull payment.

* style(web-client): run prettier.

* fix(web-client): update prod feature flags (#499)

* fix(web-client): update prod feature flags

* fix(web-client): update prod feature flags

Co-authored-by: Jean-Pierre de Villiers <[email protected]>
Co-authored-by: Francisco Rutayebesibwa <[email protected]>
Co-authored-by: Bill Guo <[email protected]>
Co-authored-by: Jonathan Ngbonga <[email protected]>
sonasi added a commit that referenced this pull request Jan 14, 2023
* refactor(backend/tests): remove superfluous mocks (#473)

* refactor(backend): use odmantic engine (#479)

* rename(backend/setting): maximum list length

* feat(backend): improve `GET` endpoint semantics

The endpoint should receive the `wallet_id` as a query parameter and
return the internal mongodb document id.

* chore(backend): remove dead code

* refactor(backend): use odmantic engine

* fix(web-client): add issuers for servers (#482)

* fix(web-client): add issuers for servers

* Update web-client/src/environments/environment.palau-prod.ts

Co-authored-by: Jean-Pierre de Villiers <[email protected]>

Co-authored-by: Jean-Pierre de Villiers <[email protected]>

* feat(web-client): Pull payment flag (#486)

* feat(web-client): Add hidePullPayment flag.

* style(web-client): run prettier

* fix(web-client): Fix ESLint error.

* style(web-client): run prettier

* fix(web-client): Change auth_map type to Object type. (#485)

* fix(web-client): Change auth_map type to Object type.

* fix(web-client): Fix ESLint error.

* feat(web-client): add auto logout (#481)

* feat(web-client): add auto logout

* feat(web-client): add ngZone for auto logout

* refactor(web-client): remove redundant isLogin variable in auto logout

* refactor(web-client): move auto logout to app component

* refactor(web-client): remove autoLogOutService from logout-button

* refactor(web-client): remove console log line in auto-logout service

* feat(web-client): add environment flag for auto logout

* fix(web-client): initialize localStorage lastAction for auto logout first

* fix(web-client): pull payment minor text fixes (#491)

* fix(cors): allow `localhost:4200` on staging (#492)

* feat(web-client): bookmark management (#451)

* fix(web-client): Update Pin Entry text for pull payment. (#497)

* fix(web-client): Update Pin Entry text for pull payment.

* style(web-client): run prettier.

* fix(web-client): update prod feature flags (#499)

* fix(web-client): update prod feature flags

* fix(web-client): update prod feature flags

* feat(web-client): Add transaction history  (#468)

* fix(web-client): display wait message while creating wallet. (#493)

* fix(web-client): display wait message and error messages while creating wallet.

* fix(web-client): clean up comments and other code.

* fix(web-client) add routertesting to asset accordian

* fix(web-client) fix txresponse import format and message html and text fields.

* fix(web-client) run prettier.

Co-authored-by: Jean-Pierre de Villiers <[email protected]>
Co-authored-by: Francisco Rutayebesibwa <[email protected]>
Co-authored-by: Bill Guo <[email protected]>
Co-authored-by: Jonathan Ngbonga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants