-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For our monthly issue metrics, Include the date range in the title and label "metrics" #841
Conversation
Question: Should we also close the metrics issues after X time? |
I don't see a reason for metrics issues to have an open status. I think we'll get notified when they're created either way? We could even mark them as "not planned" instead of "closed" to keep them out of the "business as usual" views of issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
@mfisher87 yep, anyone watching issues should get notified on create. I've updated the action to close it right after it's created as "not planned". Relevant (I wonder if we should sleep a little between open and close?) |
@mfisher87 would you say this satisfies #588? If you do want it a discussion, it should be straight forward to switch to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think closing as not-planned addresses the original need. 🚀
Makes it so we can search for all the reports easily:
https://github.com/nsidc/earthaccess/issues?q=is%3Aissue+label%3Ametrics+
And that the specific date range of the report is clear.
Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
Populate the body of the pull request with:example
closes #1
. SeeGitHub docs - Linking a pull request to an issue.
Update
If such a section does not exist, please create one. FollowCHANGELOG.md
with details about your change in a section titled## Unreleased
.Common Changelog for your additions.
Example PRs: #763
Update the documentation and/or theConsider new environment variables, function names,README.md
with details of changes to theearthaccess interface, if any.
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-support
team in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--841.org.readthedocs.build/en/841/