Feature/issue 357 #358
Merged
Feature/issue 357 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will automatically update this comment whenever this PR is modified |
betolink
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #357.
Description
This change adds a
hits()method to theDataGranuleclass, which uses the authenticated session. This overrides thehits()method from theQuerybase class, which does not use an authenticated session.The reason for this change is to enable
earthaccessto correctly determine and report the number of granules for "restricted" datasets, which are collections that only permit access if a user's authenticated Earthdata login (EDL) belongs to an Access Control List (ACL).Local test steps
Ran
earthaccess.search()on a TEMPO data collection that is not public but for which my EDL belonged to an ACL, and confirmed that an appropriate non-zero number of granules was returned. And I was able to subsequently work with the data viaearthaccess.open()andxarrayfunctions.