Encryption changes needed for NCS build system #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahasztag
requested review from
tomchy,
robertstypa,
kszromek-nordic,
nordic-mik7 and
adsz-nordic
ahasztag
force-pushed
the
NCSDK-30935_encrypt_script_build_system
branch
from
bfe3492 to
05d204d
Compare
nordicjm
requested changes
Dec 23, 2024
ncs/Kconfig
Outdated
Comment on lines
70
to
71
| help | ||
| This string is translated to the numeric KEY ID by the encryption script |
ncs/Kconfig
Outdated
Comment on lines
81
to
82
| help | ||
| Check the encryption script help for possible values |
ncs/Kconfig
Outdated
| string "The algorthm used to calculate the digest of the plaintext firmware" | ||
| help | ||
| Check the encryption script help for possible values | ||
| default "sha-256" |
There was a problem hiding this comment.
this should be a choice, not a string
ahasztag
force-pushed
the
NCSDK-30935_encrypt_script_build_system
branch
3 times, most recently
from
e25eb67 to
02253f1
Compare
tomchy
approved these changes
Jan 2, 2025
ahasztag
force-pushed
the
NCSDK-30935_encrypt_script_build_system
branch
from
02253f1 to
afe2778
Compare
|
pytest coverage results
Note: This message is automatically posted and updated by the CI (latest/test-sdk-dfu/master/294) |
adsz-nordic
approved these changes
Jan 3, 2025
ahasztag
force-pushed
the
NCSDK-30935_encrypt_script_build_system
branch
from
afe2778 to
e45136a
Compare
nordicjm
reviewed
Jan 7, 2025
Ref: NCSDK-30935 Signed-off-by: Artur Hadasz <[email protected]>
ahasztag
force-pushed
the
NCSDK-30935_encrypt_script_build_system
branch
from
41a1d3a to
9a97851
Compare
nordicjm
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: NCSDK-30935