fix: load config error

[JeyJeyGao]

Fix:

• the LoadConfigOnce function forgets the error and return a nil config and nil error next time. Updated to use sync.OnceValues to keep the returned values.

Resolves #1144

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (1118964) to head (77278ff).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/cmd/flags.go	25.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
- Coverage   72.52%   72.38%   -0.14%     
==========================================
  Files          50       50              
  Lines        3126     3125       -1     
==========================================
- Hits         2267     2262       -5     
- Misses        667      670       +3     
- Partials      192      193       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shizhMSFT]

Can you re-implement LoadConfigOnce using sync.OnceValues?

[shizhMSFT]

LGTM

[Two-Hearts]

Let's make

notation/internal/cmd/flags.go

Line 46 in 1118964

SetPflagSignatureFormat = func(fs *pflag.FlagSet, p *string) {

more elegant:

SetPflagSignatureFormat = func(fs *pflag.FlagSet, p *string) {
    config, err := configutil.LoadConfigOnce()
    if err != nil || config.SignatureFormat == "" {
	fs.StringVar(p, PflagSignatureFormat.Name, envelope.JWS, PflagSignatureFormat.Usage)
        return
    }

    // set signatureFormat from config
    fs.StringVar(p, PflagSignatureFormat.Name, config.SignatureFormat, PflagSignatureFormat.Usage)
}

[JeyJeyGao]

Let's make

notation/internal/cmd/flags.go

Line 46 in 1118964

SetPflagSignatureFormat = func(fs *pflag.FlagSet, p *string) {

more elegant:

SetPflagSignatureFormat = func(fs *pflag.FlagSet, p *string) {
    config, err := configutil.LoadConfigOnce()
    if err != nil || config.SignatureFormat == "" {
	fs.StringVar(p, PflagSignatureFormat.Name, envelope.JWS, PflagSignatureFormat.Usage)
        return
    }

    // set signatureFormat from config
    fs.StringVar(p, PflagSignatureFormat.Name, config.SignatureFormat, PflagSignatureFormat.Usage)
}

Updated.

[Two-Hearts]

LGTM

[shizhMSFT]

LGTM