You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the notation config directory lacks permission, it will trigger an error in LoadConfigOnce(). This issue was exposed after the blob signing command was added, which required calling LoadConfigOnce() twice (OCI signing + blob signing command). We need to fix it.
What did you expect to happen?
No error.
How can we reproduce it?
run chmod 0000 ~/.config/notation, then call notation command
Describe your environment
Linux x64
What is the version of your Notation CLI or Notation Library?
main branch
The text was updated successfully, but these errors were encountered:
Fix:
- the `LoadConfigOnce` function forgets the error and return a nil
config and nil error next time. Updated to use `sync.OnceValues` to keep
the returned values.
Resolves#1144
---------
Signed-off-by: Junjie Gao <[email protected]>
What is not working as expected?
When the notation config directory lacks permission, it will trigger an error in
LoadConfigOnce()
. This issue was exposed after the blob signing command was added, which required callingLoadConfigOnce()
twice (OCI signing + blob signing command). We need to fix it.What did you expect to happen?
No error.
How can we reproduce it?
run
chmod 0000 ~/.config/notation
, then call notation commandDescribe your environment
Linux x64
What is the version of your Notation CLI or Notation Library?
main
branchThe text was updated successfully, but these errors were encountered: