Make ResultReporter respect the failure status set by other plugins; add test for coveragerc from config #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for coverage "fail_under" setting with coverage options loaded from config. Due to a subtlety of test success/failure reporting, the failure from the coverage plugin is ignored in this case.
If a plugin executes wasSuccessful() before the ResultReporter plugin, ResultReporter would overwrite the result. To fix, tweak the ResultSuccessEvent creation process to start at `None`, rather than `False`, and treat `None` specially. This lets the ResultReporter clearly see whether or not a result was explicitly set to `False` by a prior plugin. Also, fix the coverage plugin to be aware of this behavior when setting a result status. closes nose-devs#395 closes nose-devs#396
|
Self-merging as maintainership of nose2 is in transition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, a goodly chunk of this is just a rebase of #395, and I don't want to pretend otherwise. I renamed the test, as it no longer fails.
coverage_config_fail_under2may not be the most inspired name, but I'm not sure it really matters.I considered pushing this rebase to #395, but decided to open a fresh PR instead.
More importantly:
NoneNonevsFalseon the incoming ResultSuccessEventResultSuccessEventThere's still #397 as a related issue --
nose2.plugins.coverageshould still either execute before or afternose2.plugins.resultwithout it mattering how it was enabled -- but this resolves #396 without tackling that work (yet). Once this is done, a solution for #397 becomes easier to work on too.