watch: reload env file for --env-file-if-exists #56643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
anonrig
approved these changes
Jan 17, 2025
JonasBa
commented
Jan 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56643 +/- ##
==========================================
- Coverage 89.21% 89.20% -0.01%
==========================================
Files 662 662
Lines 191968 191968
Branches 36955 36949 -6
==========================================
- Hits 171269 171253 -16
- Misses 13535 13551 +16
Partials 7164 7164 |
jasnell
approved these changes
Jan 19, 2025
jasnell
added
request-ci
JonasBa
force-pushed
the
jb/watch/env-exists
branch
from
6e3bc49 to
055d0ca
Compare
|
@jasnell my knowledge of the test runner is not great here, but I believe the tests were failing here due to sync loop and inner async test definition, which may have caused the first test completion to delete the file that the second test was relying on. I have split the two tests (duplicated code aside from --env cmd) and ran them manually to confirm they pass. |
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/12894525741 |
anonrig
approved these changes
Jan 21, 2025
anonrig
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
let's hope the flakiness is gone now... |
|
One more and it'll work, I promise |
JonasBa
force-pushed
the
jb/watch/env-exists
branch
from
055d0ca to
9122c4b
Compare
anonrig
approved these changes
Jan 24, 2025
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 59b3a8b |
aduh95
pushed a commit
that referenced
this pull request
Jan 27, 2025
PR-URL: #56643 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using watch mode with --env-file-if-exists, reload env correctly
ref: #49148 (comment)