Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix warning of ignoring return value #56527

Merged
merged 1 commit into from
Jan 11, 2025
Merged

crypto: fix warning of ignoring return value #56527

merged 1 commit into from
Jan 11, 2025
+1 −1

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Jan 9, 2025

CSPRNG is declared with warn_unused_result.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jan 9, 2025
@zcbenz zcbenz force-pushed the fix-ncrypto-gn branch 2 times, most recently from 96f4fb9 to 12e72d6 Compare January 9, 2025 04:16
@zcbenz zcbenz added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jan 11, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 11, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 11, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64443/ 💛

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8ca2956 into nodejs:main Jan 11, 2025
94 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8ca2956

@zcbenz zcbenz deleted the fix-ncrypto-gn branch January 11, 2025 23:40
targos pushed a commit that referenced this pull request Jan 13, 2025
@zcbenz @targos
crypto: fix warning of ignoring return value
feb3e83 
PR-URL: #56527
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jan 13, 2025
@zcbenz @Ceres6
crypto: fix warning of ignoring return value
7b35994 
PR-URL: nodejs#56527
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zcbenz @nodejs-github-bot @jasnell @anonrig @cjihrig @RafaelGSS