Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: fix unresolved promise on abortion #54030

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

readline: fix unresolved promise on abortion #54030

wants to merge 5 commits into from
+30 −4

Conversation

DanielVenable
Copy link

Fixes: #53497

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Jul 25, 2024
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60616/

@DanielVenable
Copy link
Author

Can someone merge this?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64756/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promise readline question results in unsettled promise on abortion
4 participants
@DanielVenable @nodejs-github-bot @jasnell @benjamingr