fix: electron v28 build failure due to setAcessor not having compatible signature #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this issue is also reproducible with nodejs 22.12.0. |
hmmm, in that case maybe we should use the v8 version itself in the directive? |
ThatsJustCheesy
added a commit
to GetOvert/Overt
that referenced
this pull request
Dec 26, 2024
Building node-pty on Electron 28 is broken due to an issue in dependency nodejs/nan: nodejs/nan#982 so we'll just bypass Electron 28.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for the issue reported on this closed issue: #936
This was probably introduced by #966
Let me know if there is a better way to fix this! This seems to be working for Electron v28, but I did not run the remaining tests I have.