GitHub Action to run tests on current versions of Node.js #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
reviewed
Oct 22, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
22
to
26
| # - run: npm ci | ||
| - run: npm install | ||
| # - run: npm run build --if-present | ||
| - run: npm run rebuild-tests-2017 | ||
| # - run: npm test |
There was a problem hiding this comment.
Why the commented out lines? I think npm ci would be better to use than npm install. I also don't see a rebuild-tests-2017 script in this repo, only rebuild-tests-2015.
There was a problem hiding this comment.
I recently redid the scripts 848a433
cclauss
force-pushed
the
patch-1
branch
2 times, most recently
from
45275bc to
a4c43c0
Compare
|
The tests pass so let’s merge without Node.js v23 until
|
dsanders11
reviewed
Jan 14, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
17
to
18
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 |
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v4 | |
| - uses: actions/setup-node@v4 | |
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | |
| - uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0 |
It's generally best practice to pin these to commit SHA.
There was a problem hiding this comment.
Makes Dependabot, et al chatty but let’s go for it.
Co-authored-by: David Sanders <[email protected]>
dsanders11
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test results: https://github.com/cclauss/nan/actions
@rvagg Your review, please.