Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shortfin] Adapt input_ids use for tokenization or carrying from requests #857

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[shortfin] Adapt input_ids use for tokenization or carrying from requests #857

merged 1 commit into from
Jan 22, 2025

Conversation

jinchen62
Copy link
Contributor

No description provided.

@jinchen62 jinchen62 requested a review from monorimet January 21, 2025 23:59
monorimet
monorimet reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinchen62 jinchen62 merged commit 05a94f9 into nod-ai:main Jan 22, 2025
37 checks passed
@jinchen62 jinchen62 deleted the fix_harness_inputids branch January 22, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monorimet monorimet monorimet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinchen62 @monorimet