[Llama] Do not allow configurable partitions for KVCache #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
force-pushed
the
change-kv-cache-layout
branch
from
8a48bbe to
a470e7c
Compare
dan-garvey
requested changes
Jan 22, 2025
Groverkss
force-pushed
the
change-kv-cache-layout
branch
from
f0e624d to
396bf6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been inconsistent in multiple places. KVCache generally only needs 2 partitions, one for Key and another for Value. Some places assume there are two partitions, other allow multiple partitions. This PR makes it that the cache is always partitioned into 2.