Move requirements-iree-*.txt to top level. #765
Conversation
There was a problem hiding this comment.
The failing workflow either pull in unpinned versions or if using the pinned version at least install what is expected, thus the patch does what it should.
I am still not 100% convinced as the requirements-iree-compiler.txt was supposed to keep optional (!) dependencies for shortfin only and if a user wants to install those, at least I would expect or look in the shortfin subdir. However, for what we aim for right now this is probably a huge improvement even though we might iterate later.
| # Pins | ||
| # Keep in sync with requirements-iree-compiler.txt. | ||
| # Version pins for dependencies. | ||
| # Prefer to keep the IREE git tag synced with the Python package version in the | ||
| # requirements-iree-pinned.txt file. At a minimum, the compiler from those | ||
| # packages must be compatible with the runtime at this source ref. |
There was a problem hiding this comment.
FYI @marbre I added on to the comment here
How about having a |
Seems my comment got lost (?). My concern might be not worth it as we don't pull in requirements via requirements files in our wheel (we rather have it in the |
This is prep work for #760. I also considered putting the files under `build_tools/` or `shark-ai/`, but we already have a few requirements files in the repository root. Still not as many as https://github.com/vllm-project/vllm though 😛.
This is prep work for #760.
I also considered putting the files under
build_tools/orshark-ai/, but we already have a few requirements files in the repository root. Still not as many as https://github.com/vllm-project/vllm though 😛.