Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump IREE to iree-3.1.0rc20241220." #761

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
repository: iree-org/iree
path: ${{ env.IREE_REPO_DIR }}
submodules: false
ref: iree-3.1.0rc20241220
ref: iree-3.1.0rc20241204

- name: Initalize IREE submodules
working-directory: ${{ env.IREE_REPO_DIR }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_linux_x64_asan-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
repository: iree-org/iree
path: ${{ env.IREE_SOURCE_DIR }}
submodules: false
ref: iree-3.1.0rc20241220
ref: iree-3.1.0rc20241204

- name: Initalize IREE submodules
working-directory: ${{ env.IREE_SOURCE_DIR }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci_linux_x64_nogil-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
repository: iree-org/iree
path: ${{ env.IREE_REPO_DIR }}
submodules: false
ref: iree-3.1.0rc20241220
ref: iree-3.1.0rc20241204

- name: Initalize IREE submodules
working-directory: ${{ env.IREE_REPO_DIR }}
Expand Down
2 changes: 1 addition & 1 deletion shortfin/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ add_compile_options("$<$<C_COMPILER_ID:MSVC>:/utf-8>")
add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")

# Pins
set(SHORTFIN_IREE_GIT_TAG "iree-3.1.0rc20241220")
set(SHORTFIN_IREE_GIT_TAG "iree-3.1.0rc20241204")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't tell if this hurts or helps. One workflow run at least seemed to stall: https://github.com/nod-ai/shark-ai/actions/runs/12637987386/job/35213328233?pr=761

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


# build options
option(SHORTFIN_BUILD_PYTHON_BINDINGS "Builds Python Bindings" OFF)
Expand Down
3 changes: 1 addition & 2 deletions shortfin/src/shortfin/array/storage.cc
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ storage storage::subspan(iree_device_size_t byte_offset,
iree_device_size_t byte_length) {
storage new_storage(device_, {}, timeline_resource_);
SHORTFIN_THROW_IF_ERROR(iree_hal_buffer_subspan(
buffer_, byte_offset, byte_length, host_allocator(),
new_storage.buffer_.for_output()));
buffer_, byte_offset, byte_length, new_storage.buffer_.for_output()));
return new_storage;
}

Expand Down
3 changes: 1 addition & 2 deletions shortfin/src/shortfin/local/program.cc
Original file line number Diff line number Diff line change
Expand Up @@ -663,8 +663,7 @@ void StaticProgramParameters::Load(std::filesystem::path file_path,

// Parse.
SHORTFIN_THROW_IF_ERROR(iree_io_parse_file_index(
to_iree_string_view(options.format), file_handle.get(), index_.get(),
host_allocator_));
to_iree_string_view(options.format), file_handle.get(), index_.get()));
}

// -------------------------------------------------------------------------- //
Expand Down
Loading