Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update more pins to IREE version 3.1.0rc20241220. #746

Closed
wants to merge 2 commits into from

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Jan 3, 2025

Not sure why I overlooked these in #721.

Edit: oh, the other pins are iree-3.1.0rc20241220 git refs. These are Python package pins.

Commit range: iree-org/iree@iree-3.1.0rc20241204...iree-3.1.0rc20241220

Comment on lines -3 to +4
iree-base-compiler==3.1.0rc20241204
iree-base-runtime==3.1.0rc20241204
iree-base-compiler==3.1.0rc20241220
iree-base-runtime==3.1.0rc20241220
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh? These are new errors: https://github.com/nod-ai/shark-ai/actions/runs/12604999588/job/35132936581?pr=746#step:7:479

FAILED tests/apps/sd/e2e_test.py::test_sd_server - UnboundLocalError: cannot access local variable 'response' where it is not associated with a value
FAILED tests/apps/sd/e2e_test.py::test_sd_server_bs4_dense - UnboundLocalError: cannot access local variable 'response' where it is not associated with a value
FAILED tests/apps/sd/e2e_test.py::test_sd_server_bs8_percall - UnboundLocalError: cannot access local variable 'response' where it is not associated with a value
FAILED tests/apps/sd/e2e_test.py::test_sd_server_bs4_dense_fpd2 - UnboundLocalError: cannot access local variable 'response' where it is not associated with a value
FAILED tests/apps/sd/e2e_test.py::test_sd_server_bs8_dense_fpd8 - UnboundLocalError: cannot access local variable 'response' where it is not associated with a value
>       return imgs, response.status_code
E       UnboundLocalError: cannot access local variable 'response' where it is not associated with a value

tests/apps/sd/e2e_test.py:236: UnboundLocalError

Previous errors were timeouts waiting for the server to start: https://github.com/nod-ai/shark-ai/actions/runs/12603905601/job/35129849728

Will retry to job to see if that is a consistent change in behavior...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure is sticking. The test has a bug - it is swallowing the error and trying to continue:

except requests.exceptions.RequestException as e:
print(f"Error sending the request: {e}")
return imgs, response.status_code

The real error is above in the logs:

Error sending the request: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
FAILED

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also seeing those errors on main though? https://github.com/nod-ai/shark-ai/actions/runs/12605515177/job/35134273559

argh... I can't make any changes with confidence while there are failures on main x_x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant