-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft a shark-platform meta package to organize Python packages. #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how I feel about there being a top-level Python project and projects nested below it. In my mind, this was a leaf directory but trying to think of a name:
- packaging/
- shark-platform/
- packaging/shark-platform
Basically needs to be a subdirectory somewhere. Python projects have an annoying way of repeating primary directory names... I kind of like having a packaging/ tree where we keep general project packaging infra/support and can also stash the meta package under there where it won't hurt anyone.
Cool, I was considering a new top level folder too. I also have my eye on the various |
Yeah. Would recommend refreshing a view of how others do this and see if there are more modern practices... and simplify as part of having one top level README/scripts for getting a full dev environment setup. |
Moved into |
# PyTorch uses `--index-url https://download.pytorch.org/whl/cpu`, | ||
# see https://pytorch.org/get-started/locally/. | ||
# TODO: or just drop this? if sharktank always pulls it in | ||
"iree-turbine", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sharktank
has iree-turbine
as install required, thus it is pulled in anyway.
Closing in favor of #475 |
Progress on #130, posting this for discussion.
Current local build instructions:
Current install instructions: