[libshortfin] Fix standalone Python package build to include subpackages. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
approved these changes
Sep 26, 2024
stellaraccident
pushed a commit
that referenced
this pull request
Sep 26, 2024
…subpackages." (#224) Reverts #223 This broke a build: https://github.com/nod-ai/SHARK-Platform/actions/runs/11058808130/job/30725674259#step:9:86 ``` ImportError while loading conftest '/home/runner/work/SHARK-Platform/SHARK-Platform/libshortfin/tests/conftest.py'. tests/conftest.py:10: in <module> import shortfin as sf E ModuleNotFoundError: No module named 'shortfin' ```
ScottTodd
added a commit
that referenced
this pull request
Sep 26, 2024
… subpackages." (#225) Progress on #130. This reverts #224 to re-land #223. This now uses `SOURCE_DIR` instead of `SETUPPY_DIR` to fix package discovery when running in pre-built mode, which will fix the errors reported on CI: ``` ImportError while loading conftest '/home/runner/work/SHARK-Platform/SHARK-Platform/libshortfin/tests/conftest.py'. tests/conftest.py:10: in <module> import shortfin as sf E ModuleNotFoundError: No module named 'shortfin' ``` Logs from a failed build: ``` setup.py running in pre-built mode: SOURCE_DIR = /home/runner/work/SHARK-Platform/SHARK-Platform/libshortfin BINARY_DIR = /home/runner/work/SHARK-Platform/SHARK-Platform/libshortfin/build Found libshortfin packages: ['_shortfin_default'] ``` Logs from a successful build: ``` setup.py running in pre-built mode: SOURCE_DIR = /home/runner/work/SHARK-Platform/SHARK-Platform/libshortfin BINARY_DIR = /home/runner/work/SHARK-Platform/SHARK-Platform/libshortfin/build Found libshortfin packages: ['shortfin_apps', 'shortfin', '_shortfin', 'shortfin_apps.llm', 'shortfin_apps.llm.components', 'shortfin.interop', 'shortfin.support', 'shortfin.interop.fastapi', 'shortfin.interop.support'] ``` --------- Co-authored-by: Marius Brehler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #130
Reference: https://setuptools.pypa.io/en/latest/userguide/package_discovery.html