Skip to content

Commit

Permalink
[shortfin] Add a tracing enabled CI job. (#812)
Browse files Browse the repository at this point in the history
Also update the pinned IREE commit used for building shortfin now that a
fix for Tracy on gcc has landed.
  • Loading branch information
ScottTodd authored Jan 10, 2025
1 parent 2edde8d commit 4cc3f02
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/ci-libshortfin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ jobs:
python-version: "3.12"
cmake-options:
-DCMAKE_C_COMPILER=gcc-14 -DCMAKE_CXX_COMPILER=g++-14
- name: Ubuntu (GCC 14, tracing)
runs-on: ubuntu-24.04
# Only test with GCC 14 and Python 3.12
python-version: "3.12"
cmake-options:
-DCMAKE_C_COMPILER=gcc-14 -DCMAKE_CXX_COMPILER=g++-14 -DSHORTFIN_ENABLE_TRACING=ON
- name: Windows (MSVC)
runs-on: windows-2022
exclude:
Expand Down Expand Up @@ -121,13 +127,13 @@ jobs:
cmake --build build --target all
- name: pip install shortfin
if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)'}}
if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)' && !contains(matrix.name, 'tracing') }}
working-directory: ${{ env.LIBSHORTFIN_DIR }}
run: |
pip install -v -e build/
- name: Test shortfin
if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)'}}
if: ${{ matrix.name != 'Ubuntu (Clang)(host-only)' && !contains(matrix.name, 'tracing') }}
working-directory: ${{ env.LIBSHORTFIN_DIR }}
run: |
ctest --timeout 30 --output-on-failure --test-dir build
Expand Down
2 changes: 1 addition & 1 deletion shortfin/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")
# packages must be compatible with the runtime at this source ref.
# TODO: switch back to iree-3.2.0rcYYYYMMDD style tag matching Python package
# pin after future nightly releases
set(SHORTFIN_IREE_GIT_TAG "9055c9d1f6342a061a6747ef9b385816b96a0a8f")
set(SHORTFIN_IREE_GIT_TAG "039b8b4ba8e57a3c148cd8f73370a973d64df202")


# build options
Expand Down

0 comments on commit 4cc3f02

Please sign in to comment.