App/Activity: Let the FileProvider load bundled model files #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooksong
force-pushed
the
preload-to-private-ext
branch
2 times, most recently
from
ebed8a5 to
9fe9f29
Compare
wooksong
requested review from
myungjoo,
again4you,
jaeyun-jung,
songgot,
gichan-jang,
anyj0527,
niley7464,
yeonykim2 and
a team
as code owners
wooksong
changed the title
wooksong
force-pushed
the
preload-to-private-ext
branch
2 times, most recently
from
34d82a4 to
fa3c2f0
Compare
niley7464
approved these changes
Jul 5, 2024
|
|
||
| adapter?.run { | ||
| assertEquals(2, adapter.itemCount) | ||
| assertEquals(numModelsInAssets, numModels) |
There was a problem hiding this comment.
We do not need to change model number every time using this way!
Thank you :)
|
Rebase is needed! |
This patch makes the ModelFileProvider pre-load the model files, which are packaged into the APK file. According to this change, a test case for verifying the number of models preloaded has also been updated. Signed-off-by: Wook Song <[email protected]>
wooksong
force-pushed
the
preload-to-private-ext
branch
from
fa3c2f0 to
22a3e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the ModelFileProvider pre-load the model files, which are packaged into the APK file. According to this change, a test case for verifying the number of models preloaded has also been updated.
Signed-off-by: Wook Song [email protected]