App/Activity: Change file related Java libraries to Kotlin #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niley7464
requested review from
myungjoo,
again4you,
jaeyun-jung,
songgot,
wooksong,
gichan-jang,
anyj0527,
yeonykim2 and
a team
as code owners
niley7464
commented
Jun 14, 2024
| var read: Int | ||
| while ((inFile.read(buffer).also { read = it }) != -1) { | ||
| out.write(buffer, 0, read) | ||
| am.list("models/")?.let { fileArray -> |
There was a problem hiding this comment.
Kotlin list does not raise exceptions unlike Java
https://developer.android.com/reference/kotlin/android/content/res/AssetManager#list
wooksong
reviewed
Jun 14, 2024
ml_inference_offloading/src/main/java/ai/nnstreamer/ml/inference/offloading/MainActivity.kt
Outdated
Show resolved
Hide resolved
This patch changes Java to Kotlin libraries. Privious code is created with android-studio's Convert Java to Kotlin. Signed-off-by: Yelin Jeong <[email protected]>
wooksong
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes Java to Kotlin libraries.
Privious code is created with android-studio's Convert Java to Kotlin.
Related to : #36 (comment)