Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cibot_review() API newly #686

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Added cibot_review() API newly #686

merged 1 commit into from
Dec 17, 2020

Conversation

leemgs
Copy link
Collaborator

@leemgs leemgs commented Dec 17, 2020

Fixed issue #684

This commit is to add an API to do a review result on a pull request with curl
The API consists of five arguments as folows.

  • arg1: Token number
  • arg2: Event (e.g., APPROVE, REQUEST_CHANGES, or COMMENT)
  • arg3: Description
  • arg4: Commit ID
  • arg5: API address

Note that you can use this API such as the below statement.

message="All CI checkers are successfully passed. LGTM."

cibot_review $TOKEN "APPROVE" "$message" "$input_commit"
"$GITHUB_WEBHOOK_API/$GITHUB_ACCOUNT/${PRJ_REPO_UPSTREAM_SERVER}/pulls/$input_pr/reviews

Signed-off-by: Geunsik Lim [email protected]


Fixed issue #684

This commit is to add an API to do a review result on a pull request with curl
The API consists of five arguments as folows.
 * arg1: Token number
 * arg2: Event (e.g., APPROVE, REQUEST_CHANGES, or COMMENT)
 * arg3: Description
 * arg4: Commit ID
 * arg5: API address

Note that you can use this API such as the below statement.
```bash
message="All CI checkers are successfully passed. LGTM."

cibot_review $TOKEN "APPROVE" "$message" "$input_commit"
"$GITHUB_WEBHOOK_API/$GITHUB_ACCOUNT/${PRJ_REPO_UPSTREAM_SERVER}/pulls/$input_pr/reviews
```

Signed-off-by: Geunsik Lim <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Dec 17, 2020

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #686. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

@leemgs leemgs merged commit bb9d061 into master Dec 17, 2020
@leemgs leemgs deleted the upstream-cibot-review-api branch December 21, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants