Skip to content

Commit

Permalink
Web: Updated the PR handler
Browse files Browse the repository at this point in the history
Fixed issue #609.

This commit is to remove unnecessary statements.
Until now, the some statement of debugging still are exist.
Let's remove the unnecessary and deprecated statement.

Signed-off-by: Geunsik Lim <[email protected]>
  • Loading branch information
leemgs committed Mar 24, 2020
1 parent f179c20 commit 6bf93b0
Showing 1 changed file with 4 additions and 15 deletions.
19 changes: 4 additions & 15 deletions ci/taos/webapp/pr-handler-proceed.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?php


/**
* Copyright (c) 2018 Samsung Electronics Co., Ltd. All Rights Reserved.
*
Expand Down Expand Up @@ -89,7 +88,8 @@ function display_input(){
// Check if id and password are correctly typed.
if ($id == "" || $password == "") {
echo ("<br>
Sorry, We can not do your request.<br>Please type a ID and Password. <br>
Sorry, We can not do your request because ID or Password is empty.
<br>Please type a ID and Password. <br>
<br>
<button onclick=\"goBack()\">Go Back</button>
<script>
Expand All @@ -101,11 +101,11 @@ function goBack() {
}

if ( $id == $ba_id && $password == $ba_password) {
echo ("ID and Pasword is correct.<br>");
echo ("Oooops. ID and Pasword is correct.<br>");
?>
<script>
var ba_message="[NOTICE] The CI system changes the status of the specified CI module on the PR.";
ba_message+="the comment will be displayed on the PR.";
ba_message+="The comment will be displayed on the PR.";
window.alert(ba_message);
</script>
<?php
Expand All @@ -117,17 +117,11 @@ function goBack() {
try{
flush();
echo ("Updating the PR status.<br>");
echo ("shell_exec(\"$cmd\")<br>");
exec($cmd, $output);
//system($cmd, $output);
}
catch(Exception $e){
echo "Caught exception: ",$e->getMessage(),"\nUnable to change the status of the PR....\n";
}
//DEBUG
//foreach ($output as $line) {
// print "[DEBUG] $line<br>";
//}
}

// Run the the PR report handler. The number of arguments is 4.
Expand All @@ -140,15 +134,10 @@ function goBack() {
echo ("Updating the PR status.<br>");
echo ("shell_exec(\"$cmd\")<br>");
exec($cmd, $output);
//system($cmd, $output);
}
catch(Exception $e){
echo "Caught exception: ",$e->getMessage(),"\nUnable to change the status of the PR....\n";
}
//DEBUG
//foreach ($output as $line) {
// print "[DEBUG] $line<br>";
//}
}
else {
echo ("Oooops. Your input data do not satisfied with the requirement of the handlders.<br>");
Expand Down

0 comments on commit 6bf93b0

Please sign in to comment.